Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/json null to infinity #57

Merged
merged 2 commits into from Jun 26, 2019
Merged

Feature/json null to infinity #57

merged 2 commits into from Jun 26, 2019

Conversation

rohan-deshpande
Copy link
Collaborator

@rohan-deshpande rohan-deshpande commented Jun 26, 2019 •
edited

Changed

  • Emitters and behaviours will now ensure that non-nullable properties which can be either a number or infinite will default to Infinity if null is supplied eg., life & totalEmitTimes

Added

  • Tests covering this change

@rohan-deshpande rohan-deshpande changed the base branch from master to develop June 26, 2019 20:50
@rohan-deshpande rohan-deshpande merged commit 55f695c into develop Jun 26, 2019
@rohan-deshpande rohan-deshpande deleted the feature/json-null-to-infinity branch June 26, 2019 20:52
@rohan-deshpande rohan-deshpande mentioned this pull request Jun 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@rohan-deshpande