appear doesn't load in webpack

[salvatorious]

When requiring appear in a webpack-bundled file, it doesn't appear as a function.

Adding 'module.exports = appear;' to the end of appear.js fixes this problem, but I don't know if this would break the plugin for someone using it normally. Thoughts?

[ryanjadhav]

+1

[intelligence]

+1

[salvatorious]

Update: I bit the bullet and just got rid of appearjs.
https://www.npmjs.com/package/enter-view is fantastic so far, and the offset is from the bottom of the page, not the top, which is really nice.

[dzoba]

+1

[JustinBeaudry]

@salvatorious Thanks for the update! We don't use Webpack internally so it's great to get some feedback. We could add something like the following:

  if (typeof module !== 'undefined' && typeof module.exports !== 'undefined')
    module.exports = appear;
  else
    window.appear = appear;

PR's are welcome! 😄

[kurthoefer]

Hey any progress on this? I would love to use this with my react app!

[JustinBeaudry]

@kurthoefer We're a bit swamped internally with other projects, but PR's are very welcome for this update.

[JustinBeaudry]

@salvatorious @kurthoefer Appear version 1.2.0 now supports webpack