Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flags: added "RESTICPROFILE_{FLAGNAME}" env vars #335

Merged
merged 3 commits into from
Mar 9, 2024
Merged

flags: added "RESTICPROFILE_{FLAGNAME}" env vars #335

merged 3 commits into from
Mar 9, 2024

Conversation

jkellerer
Copy link
Collaborator

@jkellerer jkellerer commented Mar 9, 2024 •
edited
Loading

Implements #334

State:

  • implementation and tests
  • documentation
  • cleanup

@codecov Codecov
Copy link

codecov bot commented Mar 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.96%. Comparing base (71ce2d0) to head (c64fb47).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #335      +/-   ##
==========================================
+ Coverage   69.88%   69.96%   +0.08%     
==========================================
  Files         118      118              
  Lines       11891    11923      +32     
==========================================
+ Hits         8309     8341      +32     
  Misses       3193     3193              
  Partials      389      389
Flag Coverage Δ
unittests 69.96% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jkellerer jkellerer changed the title Flags: added "RESTICPROFILE_{FLAGNAME}" env vars flags: added "RESTICPROFILE_{FLAGNAME}" env vars Mar 9, 2024
@jkellerer jkellerer marked this pull request as ready for review March 9, 2024 15:12
@jkellerer
Copy link
Collaborator Author

Doc links are fixed in #323. The PR is ready for review.

@creativeprojects
Copy link
Owner

Doc links are fixed

Yes, they must have noticed they messed up their links and put them back 😆

creativeprojects
creativeprojects approved these changes Mar 9, 2024
View reviewed changes
Copy link
Owner

@creativeprojects creativeprojects left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that: nice and simple. Works well 😉

Thanks 🙇🏻

@creativeprojects creativeprojects added this to the v0.27.0 milestone Mar 9, 2024
@jkellerer jkellerer merged commit 5fad1cb into creativeprojects:master Mar 9, 2024
8 of 9 checks passed
@jkellerer jkellerer deleted the ft/flags-by-env branch March 9, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@creativeprojects creativeprojects creativeprojects approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.27.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jkellerer @creativeprojects