Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade the styles to v2 of Vuetify #42

Closed
wants to merge 3 commits into from
Closed

Upgrade the styles to v2 of Vuetify #42

wants to merge 3 commits into from

Conversation

MrJmpl3
Copy link

@MrJmpl3 MrJmpl3 commented Oct 21, 2019

CHANGES:

  • Move to NPM for prevent errors (Yarn has some critical bug with the space and memory)
  • Add Prettier
  • Configure sass file of variables
  • New plugins of Creative Tim (CtCard, etc)
  • New components in other folders
  • Some components was rewrite with JSX and rename like the Vue Styles Guides
  • Styles added

TODO:

  • Refactor the upgrade page
  • Refactor code like the vuex
  • Upgrade the Filter component

@MrJmpl3
Progress
a07207e 
- Move to NPM for prevent errors (Yarn has some critical bug with the space and memory)
- Add Prettier
- Configure sass file of variables
@MrJmpl3
Progress
5b80895 
- New plugins of Creative Tim
- New components in other folders
- Some components was rewrite with JSX and rename like the Vue Styles Guides
- Styles added
@MrJmpl3
First progress already to pull request
8571100 
TODO:
- Refactor the upgrade page
- Refactor code like the vuex
- Upgrade the Filter component
@MrJmpl3 MrJmpl3 mentioned this pull request Oct 23, 2019
Open
@MrJmpl3
Copy link
Author

MrJmpl3 commented Oct 25, 2019

@dragosct10 Need something to accept the request? I can help without problems.

@dragosct
Copy link
Member

Hi! Sorry we had busy days this week, We will take a look over the pull request and if everything is good we will merge. Thank you for your understanding.

Regards,
Dragos

@MrJmpl3
Copy link
Author

MrJmpl3 commented Oct 25, 2019

Ok, If the pull request have some problems, please tell me and I'll fix it.

@MrJmpl3 MrJmpl3 mentioned this pull request Oct 27, 2019
Open
@johnleider
Copy link
Contributor

I hate to close this with all the work that you've put in, but it should have been requested before being developed on. You've made a ton of opinionated changes that go against how the project was developed and consequently, this is already done for v2.

If you have any additional questions, please reach out to us in our Discord community.

@johnleider johnleider closed this Nov 1, 2019
@MrJmpl3
Copy link
Author

MrJmpl3 commented Nov 1, 2019

Well , I tried .. (>_<)

I'll just have to wait for the new version of v2 with the Creative Tim styles..

@juanesarango juanesarango mentioned this pull request Feb 27, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MrJmpl3 @dragosct @johnleider