Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce an optional signer_payload.role field #98

Merged
merged 8 commits into from
May 28, 2024

Conversation

scouten-adobe
Copy link
Contributor

This allows credential subject’s relationship to the C2PA asset to be declared.

Closes #26.

This allows credential subject’s relationship to the C2PA asset to be declared.

Closes #26.
@scouten-adobe scouten-adobe added this to the 1.0 milestone Apr 25, 2024
@scouten-adobe scouten-adobe self-assigned this Apr 25, 2024
@scouten-adobe
Copy link
Contributor Author

FYI I did review the numerous links posted in #26 and also the Creative Work schema from schema.org. In my opinion, we are better served by keeping this as simple as possible which is why this PR is influenced by some of the roles described in those specifications, but is not a wholesale adoption of any of them.

| `cawg.translator` | The _<<_credential_subject,credential subject>>_ has adapted of this _<<C2PA asset>>_ from a similar work in another language.
|=======================

Other values for `role` MAY be used with the understanding that they may not be well understood by *<<_identity_assertion,identity assertion>>* consumers. Values for `role` that begin with the prefix `cawg.` are reserved for the use of the Creator Assertions Working Group and MUST NOT be used unless defined in a this or a future version of this specification.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should you point at the relevant section of C2PA for namespacing rules. so that all other roles are namespaced??

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lrosenthol can you point me to that section? IIRC when we discussed a few weeks ago, that wasn't yet formalized.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lrosenthol the closest section in C2PA that I could find is §6.2 Labels, which appears to be specific to assertion labels and thus not usable here. Is there another section I'm missing?

docs/modules/ROOT/pages/index.adoc Outdated Show resolved Hide resolved

The _<<_credential_holder,credential holder>>_ MAY choose to describe the relationship of the _<<_credential_subject,credential subject>>_ to the _<<C2PA asset>>_ by adding a `role` field to `signer_payload`.

The following values for `role` are defined. It is recommended that the value of `role` be one of the following values and that any user experience that presents the content of an *<<_identity_assertion,identity assertion>>* be prepared to describe these roles in the same human language as the surrounding interface:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider moving this into its own standard?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per @chalford comment, is there a JSON-LD vocabulary for this kind of role that could be defined?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per Nigel comment, do we need to allow multiple roles per named actor?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Above feedback was from last Monday (29 April)'s meeting. I'm planning to push back on that in the interest of keeping this specification simpler. I think we could add a JSON-LD vocabulary here in a subsequent release if there's significant pushback.

# Conflicts:
#	docs/modules/ROOT/pages/index.adoc
#	docs/modules/ROOT/partials/version-history.adoc
# Conflicts:
#	docs/modules/ROOT/pages/index.adoc
#	docs/modules/ROOT/partials/version-history.adoc
# Conflicts:
#	docs/modules/ROOT/pages/index.adoc
#	docs/modules/ROOT/partials/version-history.adoc

(Also, apply credential subject -> named actor change to this PR.)
@scouten-adobe scouten-adobe merged commit 1e8e721 into main May 28, 2024
1 check passed
@scouten-adobe scouten-adobe deleted the define-subject-role branch May 28, 2024 19:26
@github-actions github-actions bot locked and limited conversation to collaborators May 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Describe credential holder’s role in relation to the asset
2 participants