Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: share certificate #293

Merged
merged 8 commits into from
Nov 22, 2023
Merged

refactor: share certificate #293

merged 8 commits into from
Nov 22, 2023

Conversation

nishad-ayanworks
Copy link
Contributor

What

  • Refactor share credentials templates and used svg image.
  • Implemented socket in bulk issuance.

tipusinghaw and others added 8 commits November 22, 2023 12:19
@tipusinghaw
fix: file upload blob issue
e41a9d0 
Signed-off-by: tipusinghaw <tipu.singh@ayanworks.com>
@pallavighule
Error message emitted during the bulk issuance process failed through…
b26e7fb 
… sockets (#290)

* refact:added function for emmiting socket message when issuance process failed

Signed-off-by: pallavicoder <pallavi.ghule@ayanworks.com>

* refact:emmited error-in-bulk-issuance-process message

Signed-off-by: pallavicoder <pallavi.ghule@ayanworks.com>

* refact:emmited socket message when bulk issuance process failed

Signed-off-by: pallavicoder <pallavi.ghule@ayanworks.com>

---------

Signed-off-by: pallavicoder <pallavi.ghule@ayanworks.com>
@tipusinghaw
fix: bulk-issuance status
dfebcc6 
Signed-off-by: tipusinghaw <tipu.singh@ayanworks.com>
@nishad-ayanworks
Merge pull request #289 from credebl/file-upload-blob-issue
24ca7c7 
fix: file upload blob issue
@bhavanakarwade
refactor: post api for share user credential
e445db0 
Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
@bhavanakarwade
Merge branch 'develop' of https://github.com/credebl/platform into ce…
f35baba 
…rtificate-share
@nishad-ayanworks
Merge pull request #292 from credebl/certificate-share
17d71b6 
refactor: Resolved puppeteer library issue
@nishad-ayanworks
Merge branch 'develop' of https://github.com/credebl/platform into de…
66129d8 
…velop-main-bulk-issuances
@nishad-ayanworks nishad-ayanworks self-assigned this Nov 22, 2023
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

KulkarniShashank
KulkarniShashank approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@KulkarniShashank KulkarniShashank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@KulkarniShashank KulkarniShashank merged commit c5077e3 into main Nov 22, 2023
5 checks passed
@nishad-ayanworks nishad-ayanworks deleted the develop-main-bulk-issuances branch December 6, 2023 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KulkarniShashank KulkarniShashank KulkarniShashank approved these changes

Assignees

@nishad-ayanworks nishad-ayanworks

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nishad-ayanworks @KulkarniShashank @tipusinghaw @pallavighule @bhavanakarwade