Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: email validations throughout application #361

Merged
merged 5 commits into from
Jan 5, 2024

Conversation

bhavanakarwade
Copy link
Contributor

What

  • Refactoring email validations throughout the application
  • Applied case insensitive validations while logging onto the platform

Why

  • To ensure uniformity in email validation logic, making it easier to manage, update, and debug across the entire application
  • To improve user experience by accommodating variations in letter case and ensuring a smoother authentication process.

How

  • Evaluate existing email validation implementations
  • Use standardised approaches to promote code consistency and reduce redundancy

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
@bhavanakarwade bhavanakarwade added the enhancement New feature or request label Dec 19, 2023
@bhavanakarwade bhavanakarwade self-assigned this Dec 19, 2023
@@ -61,7 +61,7 @@ export class AuthzController {
* @returns Email sent success
*/
@Post('/verification-mail')
@ApiResponse({ status: 201, description: 'Success', type: ApiResponseDto })
@ApiResponse({ status: HttpStatus.CREATED, description: 'Success', type: ApiResponseDto })
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check if we can replace the status with HttpStatus.OK

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
Copy link
Contributor

@nishad-ayanworks nishad-ayanworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve comment

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
Copy link

sonarcloud bot commented Jan 5, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@nishad-ayanworks nishad-ayanworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@nishad-ayanworks nishad-ayanworks merged commit 05e8a15 into develop Jan 5, 2024
2 checks passed
@bhavanakarwade bhavanakarwade deleted the backend-bug-fixes branch January 30, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants