Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refcator: get all schemas api #647

Closed
wants to merge 1 commit into from

Conversation

bhavanakarwade
Copy link
Contributor

What?

  • Modify /platform/schemas (get all schemas from platform) API.
  • Modify /platform/ledgers (get all ledgers from platform) API.
  • Modify /platform/network/url/{indyNameSpace} (get network URL from platform) API.

1.Checked validations on payload.
2.Refactor response
3.Ensured consistency of API status codes.
4.Modified the NATS function.

Why?

  • The implementation of a well-defined interface enhances code readability and makes the structure of the API response more explicit.
  • Ensuring consistent API status codes improves communication between different components of the system and enhances overall reliability.

How?

Replaced the return type with a well-defined interface to enhance code clarity.
Checked and standardized API status codes to ensure a uniform response.
Modified the NATS function to accommodate the adjustments made in the API.

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
@bhavanakarwade bhavanakarwade changed the base branch from main to develop April 8, 2024 11:07
Copy link

sonarcloud bot commented Apr 8, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
20 Security Hotspots
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@bhavanakarwade bhavanakarwade deleted the refactor/ledger-service branch April 8, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant