Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using ProductType enum array [29104] #58

Merged
merged 2 commits into from Aug 14, 2022
Merged

Using ProductType enum array [29104] #58

merged 2 commits into from Aug 14, 2022
+17 −2

Conversation

lqgioan
Copy link
Contributor

@lqgioan lqgioan commented Aug 10, 2022

Description

Used ProductType enum array instead of string array.

Motivation & Context

Ticket: https://app.shortcut.com/credify/story/29104/mobile-sdk-using-producttype-enum-array

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@lqgioan lqgioan requested a review from ngo275 August 10, 2022 09:20
ngo275
ngo275 reviewed Aug 10, 2022
View reviewed changes
Copy link
Member

@ngo275 ngo275 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update README

@lqgioan
Copy link
Contributor Author

lqgioan commented Aug 12, 2022

I updated the README file

@lqgioan lqgioan mentioned this pull request Aug 14, 2022
Merged
@ngo275 ngo275 merged commit 2a0b0df into development Aug 14, 2022
@ngo275 ngo275 deleted the gioanle/sc-29104-mobile-sdk-using-producttype-enum-array branch August 14, 2022 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngo275 ngo275 ngo275 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lqgioan @ngo275