Skip to content

Commit

Permalink
Latest pattern
Browse files Browse the repository at this point in the history
  • Loading branch information
big-andy-coates committed Nov 5, 2022
1 parent ccfa529 commit a3a6b98
Show file tree
Hide file tree
Showing 4 changed files with 17 additions and 3 deletions.
13 changes: 13 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,16 @@
### Labels
Mark your PRs with the following labels, as appropriate:
- `breaking-change`: if the PR includes a breaking change
- `enhancement`: if the PR enables / completes a new feature
- `bug`: if the PR fixes a bug.
- `dependencies`: if the PR updates dependencies
- `documentation **`: If the PR doc-only changes
- `subtask **`: If the PR is only part of a new feature. Ensure final PR is marked with `enhancement`.
- `chore **`: a maintenance / non-feature released task of no interest to users.

Labels marked with `**` are excluded from release notes

### Reviewer checklist
- [ ] Ensure relevant issues are linked (description should include text like "Fixes #<issue number>")
- [ ] Ensure correct labels applied
- [ ] Ensure any appropriate documentation has been added or amended
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
- name: Build
env:
COVERALLS_REPO_TOKEN: ${{ secrets.COVERALLS_REPO_TOKEN }}
run: ./gradlew check coveralls
run: ./gradlew javadoc check coveralls
- name: Publish
if: github.event_name == 'push' || github.event.inputs.publish_artifacts == 'true'
env:
Expand Down
4 changes: 3 additions & 1 deletion build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,9 @@ subprojects {
apply(plugin = "creek-common-convention")
apply(plugin = "creek-module-convention")

if (!name.startsWith("test-")) {
if (name.startsWith("test-")) {
tasks.javadoc { onlyIf { false } }
} else {
apply(plugin = "creek-publishing-convention")
apply(plugin = "jacoco")
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ plugins {
group = "org.creekservice"

java {
modularity.inferModulePath.set(false)
sourceCompatibility = JavaVersion.VERSION_11
targetCompatibility = JavaVersion.VERSION_11
}
Expand Down

0 comments on commit a3a6b98

Please sign in to comment.