Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure Docker container logs are captured on error #235

Merged
merged 1 commit into from Mar 7, 2023
Merged

Ensure Docker container logs are captured on error #235

merged 1 commit into from Mar 7, 2023

Conversation

big-andy-coates
Copy link
Member

If a Docker containers fails to start, the logs were not getting picked up correctly. With this fix the logs are grabbed before the container is stopped, which loses the logs.

Tests added to ensure this works as expected.

Reviewer checklist

  • Read the contributing guide
  • PR should be motivated, i.e. what does it fix, why, and if relevant, how
  • Ensure relevant issues are linked (description should include text like "Fixes #")
  • Ensure any appropriate documentation has been added or amended

@big-andy-coates
Ensure Docker container logs are captured on error
e58ee2c 
If a Docker containers fails to start, the logs were not getting picked up correctly. With this fix the logs are grabbed _before_ the container is stopped, which loses the logs.

Tests added to ensure this works as expected.
@big-andy-coates big-andy-coates added the bug Something isn't working label Mar 7, 2023
@big-andy-coates big-andy-coates requested a review from a team as a code owner March 7, 2023 17:31
@coveralls
Copy link

Coverage Status

Coverage: 98.8%. Remained the same when pulling e58ee2c on logs-on-failure into ba8a508 on main.

@big-andy-coates big-andy-coates merged commit 9b335ff into main Mar 7, 2023
@big-andy-coates big-andy-coates deleted the logs-on-failure branch March 7, 2023 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@big-andy-coates @coveralls