Add git version to non-release builds in About view #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@creepymonster may we please get this merged in? |
DAcodedBEAT
force-pushed
the
add-git-version
branch
from
7884abb
to
80c0058
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: #564
When I first downloaded this application from TestFlight, I was unable to connect the sensor via LibreLinkUp. After some digging, I was able to figure out that this was resolved in 3667f43, but these updates were never pushed to TestFlight.
By adding this new field to the About view, users can see the latest Git commit used to build the application (and can also copy this by clicking on the field) and can more-easily figure out if their application is up-to-date with the changes from this repository.
note: The git version is only set on non-release builds (meaning TestFlight and local development builds) since production releases should have their own unique version set.