Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Locale event emitted before locale loaded #4

Closed
Trakkasure opened this issue Sep 6, 2016 · 1 comment
Closed

Locale event emitted before locale loaded #4

Trakkasure opened this issue Sep 6, 2016 · 1 comment

Comments

@Trakkasure
Copy link

Trakkasure commented Sep 6, 2016 •
edited
Loading

In the case of ajax or Webpack code splitting using File adapter, the locale event is emitted before the callback is called when the translations are actually available.

This cause issues, for example, with React in it's context.

An adjustment of translate on line 115 moving 117 into a shim callback for the load callback should resolve this issue.
Trakkasure pushed a commit to Trakkasure/translate-maker that referenced this issue Sep 6, 2016
Fixed issue creolingo#4. Waits for callback to be called before emitt…
ca56922 
…ing locale event.
@Trakkasure Trakkasure mentioned this issue Sep 6, 2016
Merged
seeden added a commit that referenced this issue Sep 7, 2016
@seeden
Merge pull request #5 from Trakkasure/master
d60d34f 
Fixed issue #4. Waits for callback to be called before emitting local…
@seeden
Copy link
Collaborator

seeden commented Sep 7, 2016

merged in new version 0.4.7
thank you @Trakkasure

@seeden seeden closed this as completed Sep 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Trakkasure @seeden