Allow middleware to accept parameters #209
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So by editing these two files can I set different roles between the admin and user accounts? |
|
@Davides98 No, you will still need to use a package such as spatie/permission to actually have working roles/permissions and write the code for the store. About the code, only thing I would change is use camelCase for the variables and make the role code pass eslint (spacing issues). |
|
@xazinji can you help me for this? |
|
This code is not intended to be a complete roles/permissions implementation. A lot more work would still need to be done. See my comment on #218 for a bit more detail. |
|
Merged #289 |
|
@cretueusebiu @jimohalloran Can you create an example of this feature? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for code in issue #124 ... @cretueusebiu I notice this change hasn't been included yet, so I've created this PR for you to help with the process. This is just @imade-nl 's code form the ticket with a little additional documentation.