Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in schema.go #461

Closed
marcidelux opened this issue Sep 25, 2022 · 7 comments · Fixed by #478
Closed

Error in schema.go #461

marcidelux opened this issue Sep 25, 2022 · 7 comments · Fixed by #478

Comments

@marcidelux
Copy link

Hi !

There is a small error in schema.go at line 767 :
err := etreeutils.TransformExcC14n(el, canonicalizerPrefixList)
The TransformExcC14n requires 3 argument, but only 2 were given.
When I set the comments to false it was working fine. Can you please make a quick fix, otherwise I have to do an ugly monkey fix solution and that's bad for all of us :D
Thank you very much for your work.

@mikey923
Copy link

Same issue here.

@yanlong-turingvideo
Copy link

Same issue here. Maybe the lastest version(v0.4.8) depend github.com/russellhaering/goxmldsig(v1.1.1), it should support v1.2.0

@ariefsn
Copy link

ariefsn commented Oct 4, 2022

any update?

@stephen-digicert
Copy link

yeah same issue here

@marcidelux
Copy link
Author

Hi!

I told that it will be ugly, but I made a monkey patch:
Place this in to the go.mod file before requre part: replace github.com/crewjam/saml v0.4.8 => github.com/marcidelux/saml v0.4.10
Yeah I know the version number is bigger, but it was necessary when I was messing with it, doesn`t matter it will be removed when the problem is fixed.

scudette added a commit to Velocidex/saml that referenced this issue Oct 19, 2022
Fix dependency issue crewjam#461
@anthonyalberto
Copy link

Another possible workaround is to stick with goxmldsig v1.1.1 for now, until this is addressed.

@greenpau
Copy link
Sponsor Contributor

greenpau commented Nov 6, 2022

@crewjam , same issue here. Could you please fix it and release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants