Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Deleting a file when only_changed is enabled results in error #31

Closed
J-Fields opened this issue Nov 20, 2020 · 0 comments · Fixed by #32, codedge/statamic-magiclink#57, codedge/laravel-selfupdater#175, villa-brocante/contao-google-shopping-feed#28 or codedge/coding-challenges#3
Closed

[BUG] Deleting a file when only_changed is enabled results in error #31

J-Fields opened this issue Nov 20, 2020 · 0 comments · Fixed by #32, codedge/statamic-magiclink#57, codedge/laravel-selfupdater#175, villa-brocante/contao-google-shopping-feed#28 or codedge/coding-challenges#3
Labels
bug Something isn't working

Comments

@J-Fields
Copy link
Contributor

What exactly happened?
Steps to reproduce the behavior:

  1. Configure to prettify on push with only_changed: true
  2. Delete a file that would normally be prettified
  3. Commit & push
  4. See error: fatal: pathspec 'deletedFile.js' did not match any files

What should've happened?
Deleted files should be excluded from prettification

This should be fixable by passing --diff-filter=d to git diff
@J-Fields J-Fields added the bug Something isn't working label Nov 20, 2020
J-Fields added a commit to J-Fields/prettier_action that referenced this issue Nov 20, 2020
@J-Fields
Exclude deleted files when using only_changed
ce4e1eb 
Fixes creyD#31
@J-Fields J-Fields mentioned this issue Nov 20, 2020
Merged
@creyD creyD closed this as completed in #32 Dec 17, 2020
This was referenced Mar 12, 2021
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@J-Fields