Bugfix for quantile regression #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix bug where quantile regression would throw exception when predicting on a single row.
Update regressor.py
Add test for single row quantile prediction.
crflynn
requested changes
Nov 22, 2021
Add update as requested by crflynn to simplify reshape
Updated to remove unnecessary if statement.
|
Failure here is unrelated to your changes. I'll fix it and get it merged later today. |
|
Awesome! I did also add a unit test for this edge case so hopefully that will keep this issue from coming back as well. |
crflynn
approved these changes
Nov 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for writing this great wrapper!
I'd like to propose a minor bugfix. It turns out that quantile regression throws an exception when it tries to predict on one row. I have added a reshape call to fix this edge case.