Skip to content
verify

[WIP-Refactor part 1] Move container mounts to internal/factory/container #11661

Sign in to view logs

[WIP-Refactor part 1] Move container mounts to internal/factory/container

[WIP-Refactor part 1] Move container mounts to internal/factory/container #11661

Triggered via pull request March 11, 2024 10:32
@hasan4791hasan4791
synchronize #7859
hasan4791:refactor-part-1
Status Failure
Total duration 1m 58s
Artifacts –

verify.yml

on: pull_request
lint
40s
lint
lint-markdown
6s
lint-markdown
shellcheck
13s
shellcheck
shfmt
10s
shfmt
space-at-eol
6s
space-at-eol
docs
1m 50s
docs
vendor
25s
vendor
log-capitalization
8s
log-capitalization
verify-config-template
6s
verify-config-template
dependencies
9s
dependencies
typos
6s
typos
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 1 warning
lint: internal/factory/container/container_log_path_test.go#L1
: # github.com/cri-o/cri-o/internal/factory/container_test [github.com/cri-o/cri-o/internal/factory/container.test]
lint: internal/factory/container/mounts_linux_test.go#L198
too many arguments in call to container.GetContainerInfo(sut).SetupHostPropMounts
lint: internal/factory/container/container.go#L28
dupImport: package is imported 2 times under different aliases on lines 28 and 29 (gocritic)
lint: internal/factory/container/container.go#L29
dupImport: package is imported 2 times under different aliases on lines 28 and 29 (gocritic)
lint: internal/factory/container/mounts.go#L33
hugeParam: containerInfo is heavy (88 bytes); consider passing it by pointer (gocritic)
lint: internal/factory/container/mounts.go#L56
hugeParam: containerInfo is heavy (88 bytes); consider passing it by pointer (gocritic)
lint: internal/factory/container/mounts.go#L226
importShadow: shadow of imported from 'github.com/containers/storage/pkg/mount' package 'mount' (gocritic)
lint: internal/factory/container/mounts.go#L254
importShadow: shadow of imported from 'github.com/containers/storage/pkg/mount' package 'mount' (gocritic)
lint: internal/factory/container/mounts_linux.go#L24
dupImport: package is imported 2 times under different aliases on lines 24 and 25 (gocritic)
lint: internal/factory/container/mounts_linux.go#L25
dupImport: package is imported 2 times under different aliases on lines 24 and 25 (gocritic)
shellcheck
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: lumaxis/shellcheck-problem-matchers@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.