Skip to content

Commit

Permalink
Merge pull request #1594 from wking/consolidate-phony
Browse files Browse the repository at this point in the history
Makefile: Consolidate .PHONY entries
  • Loading branch information
Mrunal Patel committed Jun 5, 2018
2 parents 763baf7 + d9466ce commit 540ebd6
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions Makefile
Expand Up @@ -187,7 +187,6 @@ uninstall:
rm -f $(MANDIR)/man8/$$(basename $${i}); \
done

.PHONY: .gitvalidation
# When this is running in travis, it will only check the travis commit range
.gitvalidation: .gopathok
ifeq ($(TRAVIS),true)
Expand All @@ -196,8 +195,6 @@ else
GIT_CHECK_EXCLUDE="./vendor" $(GOPATH)/bin/git-validation -v -run DCO,short-subject,dangling-whitespace -range $(EPOCH_TEST_COMMIT)..HEAD
endif

.PHONY: install.tools

install.tools: .install.gitvalidation .install.gometalinter .install.md2man .install.release

.install.release:
Expand Down Expand Up @@ -233,6 +230,7 @@ install.tools: .install.gitvalidation .install.gometalinter .install.md2man .ins
fi

.PHONY: \
.gitvalidation \
bin/conmon \
bin/crio \
bin/pause \
Expand All @@ -243,5 +241,6 @@ install.tools: .install.gitvalidation .install.gometalinter .install.md2man .ins
gofmt \
help \
install \
install.tools \
lint \
uninstall

0 comments on commit 540ebd6

Please sign in to comment.