port error: check for error

Signed-off-by: Peter Hunt <pehunt@redhat.com>
cri-o · Jul 27, 2020 · 61a236b · 61a236b
1 parent 7854af4
commit 61a236b
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/internal/oci/runtime_oci.go b/internal/oci/runtime_oci.go
@@ -874,8 +874,9 @@ func (r *runtimeOCI) PortForwardContainer(c *Container, port int32, stream io.Re
 	defer func() {
 		if emptyStreamOnError {
 			go func() {
-				_, copyError := pools.Copy(ioutil.Discard, stream)
-				logrus.Errorf("error closing port forward stream after other error: %v", copyError)
+				if _, copyError := pools.Copy(ioutil.Discard, stream); copyError != nil {
+					logrus.Errorf("error closing port forward stream after other error: %v", copyError)
+				}
 			}()
 		}
 	}()