criocli: Avoid parsing the config twice

This splits out the config file loading and commandline argument
processing from GetConfigFromContext() so that subcommand like `crio
config' and `crio wipe` are able to fetch the configuration from the
context without reloading the config files. Apart from being inefficient
this also caused issues with StringSlice values being handled wrong.

Closes #3862

Signed-off-by: Ralf Haferkamp <rhafer@suse.com>

cmd/crio/main.go

@@ -144,7 +144,7 @@ func main() {
 	}...)
 
 	app.Before = func(c *cli.Context) (err error) {
-		config, err := criocli.GetConfigFromContext(c)
+		config, err := criocli.GetAndMergeConfigFromContext(c)
 		if err != nil {
 			return err
 		}

internal/criocli/criocli.go

@@ -27,6 +27,14 @@ func GetConfigFromContext(c *cli.Context) (*libconfig.Config, error) {
 	if !ok {
 		return nil, fmt.Errorf("type assertion error when accessing server config")
 	}
+	return config, nil
+}
+
+func GetAndMergeConfigFromContext(c *cli.Context) (*libconfig.Config, error) {
+	config, err := GetConfigFromContext(c)
+	if err != nil {
+		return nil, err
+	}
 	if err := mergeConfig(config, c); err != nil {
 		return nil, err
 	}