Aim to drop containers/podman as a dependency

[kannon92]

As we were working on ##7865, I noticed that we have some dependencies on podman.

@haircommander mentioned that we should start phasing that out or moving components that we need to c/common.

From a quick search, we use rootless, annotations, criu, and errorhandling.

• remove annotations: Remove Podman annotations package dependency #7867
• remove checkpoint/criu utilties Added checkpoint specific functions containers/common#1904
• rootless Use unshare instead of rootless #7990
• selinux
• /specgen/generate: drop specgen from crio #7891
• lookup: Remove Podman lookup dependency #7893
• errorhandling: Remove Podman errorhandling package dependency #7868

Maybe we can start moving what we need to c/common so we can drop this as a library.
kehannon@kehannon-thinkpadp1gen4i:~/Work/cri-o$ grep -r 'podman' * --exclude-dir=vendor

internal/config/cgmgr/cgroupfs_linux.go:        "github.com/containers/podman/v4/pkg/rootless"
internal/config/cgmgr/systemd_linux.go: "github.com/containers/podman/v4/pkg/rootless"
internal/config/device/device_linux.go: createconfig "github.com/containers/podman/v4/pkg/specgen/generate"
internal/factory/container/container_test.go:   "github.com/containers/podman/v4/pkg/annotations"
internal/factory/container/container.go:        "github.com/containers/podman/v4/pkg/annotations"
internal/lib/checkpoint.go:     "github.com/containers/podman/v4/pkg/annotations"
internal/lib/checkpoint.go:     "github.com/containers/podman/v4/pkg/checkpoint/crutils"
internal/lib/checkpoint.go:     // To correctly track deleted files, let's go through the output of 'podman diff'
internal/lib/restore.go:        "github.com/containers/podman/v4/pkg/annotations"
internal/lib/restore.go:        "github.com/containers/podman/v4/pkg/checkpoint/crutils"
internal/lib/checkpoint_test.go:        "github.com/containers/podman/v4/pkg/criu"
internal/lib/container_server.go:       "github.com/containers/podman/v4/pkg/annotations"
internal/lib/container_server_freebsd.go:       "github.com/containers/podman/v4/pkg/annotations"
internal/lib/container_server_test.go:// Right now these are the only dependency for podman/v4/pkg/annotations
internal/lib/restore_test.go:   "github.com/containers/podman/v4/pkg/criu"
internal/oci/oci_test.go:       "github.com/containers/podman/v4/pkg/criu"
internal/oci/runtime_oci.go:    "github.com/containers/podman/v4/pkg/checkpoint/crutils"
internal/oci/runtime_oci.go:    "github.com/containers/podman/v4/pkg/criu"
internal/oci/runtime_vm.go:     "github.com/containers/podman/v4/pkg/annotations"
internal/storage/utils.go:// by CRI-O sandboxes and containers differ from podman container and
internal/storage/image_linux.go:        "github.com/containers/podman/v4/pkg/rootless"
internal/storage/image.go:      "github.com/containers/podman/v4/pkg/rootless"
Makefile:CONTAINER_RUNTIME ?= podman
pkg/config/config.go:   "github.com/containers/podman/v4/pkg/rootless"
README.md:and [Podman](https://github.com/containers/podman).
README.md:[You can configure CRI-O][podman-hooks] to inject
README.md:[podman-hooks]: https://github.com/containers/podman/blob/v3.0.1/pkg/hooks/README.md
server/container_checkpoint_test.go:    "github.com/containers/podman/v4/pkg/criu"
server/container_restore.go:    "github.com/containers/podman/v4/pkg/annotations"
server/container_restore.go:    "github.com/containers/podman/v4/pkg/errorhandling"
server/container_restore_test.go:       "github.com/containers/podman/v4/pkg/criu"
server/nri-api.go:      stdannotations "github.com/containers/podman/v4/pkg/annotations"
server/container_create_linux.go:       "github.com/containers/podman/v4/pkg/rootless"
server/container_create_linux.go:       selinux "github.com/containers/podman/v4/pkg/selinux"
server/sandbox_run_freebsd.go:  "github.com/containers/podman/v4/pkg/annotations"
server/sandbox_run_freebsd.go:  selinux "github.com/containers/podman/v4/pkg/selinux"
server/sandbox_run_linux.go:    "github.com/containers/podman/v4/pkg/annotations"
server/sandbox_run_linux.go:    "github.com/containers/podman/v4/pkg/rootless"
server/sandbox_run_linux.go:    selinux "github.com/containers/podman/v4/pkg/selinux"
test/checkcriu/checkcriu.go:    "github.com/containers/podman/v4/pkg/criu"
test/copyimg/copyimg.go:        "github.com/containers/podman/v4/pkg/rootless"
test/testdata/Dockerfile:# Placing it here to avoid saving its contents by podman.
test/crio-wipe.bats:# podman.
test/crio-wipe.bats:PODMAN_BINARY=${PODMAN_BINARY:-$(command -v podman || true)}
test/crio-wipe.bats:function run_podman_with_args() {
test/crio-wipe.bats:    run_podman_with_args stop -a
test/crio-wipe.bats:    run_podman_with_args rm -fa
test/crio-wipe.bats:@test "don't clear podman containers" {
test/crio-wipe.bats:    run_podman_with_args run --name test -d quay.io/crio/fedora-crio-ci:latest top
test/crio-wipe.bats:    run_podman_with_args container exists test
test/crio-wipe.bats:@test "do clear podman containers when shutdown file not found" {
test/crio-wipe.bats:    run_podman_with_args run --name test quay.io/crio/fedora-crio-ci:latest ls
test/crio-wipe.bats:    # all podman containers would be stopped after a reboot
test/crio-wipe.bats:    run_podman_with_args stop -a
test/crio-wipe.bats:    run ! run_podman_with_args container exists test
test/crio-wipe.bats:@test "fail to clear podman containers when shutdown file not found but container still running" {
test/crio-wipe.bats:    # all podman containers would be stopped after a reboot
test/crio-wipe.bats:    run_podman_with_args run --name test -d quay.io/crio/fedora-crio-ci:latest top
test/crio-wipe.bats:@test "internal_wipe don't clear podman containers" {
test/crio-wipe.bats:    run_podman_with_args run --name test -d quay.io/crio/fedora-crio-ci:latest top
test/crio-wipe.bats:    run_podman_with_args ps -a | grep test
transfer.md:recommended to leverage additional tools like [Podman](https://github.com/containers/podman).
transfer.md:commands to perform actions like executing commands within a container (`podman exec`),
transfer.md:inspecting container metadata (`podman inspect`),
transfer.md:viewing container logs (`podman logs`), and many others.
transfer.md:| `docker inspect` | `podman inspect`                             |
transfer.md:| `docker logs`    | `podman logs`                                |
transfer.md:| `docker stats`   | `podman stats`                               |
tutorials/tracing.md:podman run -it --rm --network host jaegertracing/all-in-one:1.41.0
tutorials/tracing.md:podman run -it --rm --network host \
utils/utils_test.go:    "github.com/containers/podman/v4/pkg/rootless"
utils/utils.go: "github.com/containers/podman/v4/pkg/lookup"

[adrianreber]

When implementing the checkpoint/restore support I tried to share code between Podman and CRI-O as much as possible. I can move some code to go-criu if that makes more sense to CRI-O.

[saschagrunert]

@adrianreber would the code fit into c/common? Or is it used by other tools than Podman and CRI-O?

[adrianreber]

@adrianreber would the code fit into c/common? Or is it used by other tools than Podman and CRI-O?

I also started to use some of it in containerd. It probably depends, some code depends on

	"github.com/containers/storage/pkg/archive"
	"github.com/opencontainers/selinux/go-selinux/label"

That is code I would not put in go-criu because I would not want those dependencies.

I think "github.com/containers/podman/v4/pkg/criu" could definitely move to go-criu.

"github.com/containers/podman/v4/pkg/checkpoint/crutils" that would need to be in c/common and go-criu.

[adrianreber]

Part of the checkpoint/restore related code is available in c/common now: containers/common#1904

Another part of the checkpoint/restore related code will be available via go-criu: checkpoint-restore/go-criu#165