Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error messages on missing runtime #1216

Merged
merged 1 commit into from
Jan 6, 2018
Merged

Conversation

rhatdan
Copy link
Contributor

@rhatdan rhatdan commented Dec 11, 2017

Signed-off-by: Daniel J Walsh dwalsh@redhat.com

- What I did

- How I did it

- How to verify it

- Description for the changelog

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes labels Dec 11, 2017
@TomSweeneyRedHat
Copy link
Contributor

LGTM, does this fix #1215?

@rhatdan
Copy link
Contributor Author

rhatdan commented Dec 11, 2017

Not sure it fixes it, but does make it a bit easier to diagnose.

@mrunalp
Copy link
Member

mrunalp commented Dec 11, 2017

/test all

@rhatdan
Copy link
Contributor Author

rhatdan commented Dec 12, 2017

/test e2e_rhel

Also stat.h is included twice,
Add more info on log file name and error when failing to open.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
@rhatdan
Copy link
Contributor Author

rhatdan commented Dec 18, 2017

/test all

@rhatdan
Copy link
Contributor Author

rhatdan commented Dec 19, 2017

/retest

@mrunalp
Copy link
Member

mrunalp commented Jan 5, 2018

restarted travis

@rhatdan
Copy link
Contributor Author

rhatdan commented Jan 6, 2018

@mrunalp @runcom Ok to merge?

@runcom runcom merged commit 6f4d7c1 into cri-o:master Jan 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants