Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes #15

Merged
merged 3 commits into from
Sep 17, 2016
Merged

Various fixes #15

merged 3 commits into from
Sep 17, 2016

Conversation

runcom
Copy link
Member

@runcom runcom commented Sep 17, 2016

@mrunalp PTAL - see individual commits, the various format fixes in conmon.c have been done with vim following the linux guidelines with https://github.com/crosbymichael/vim-cfmt

I got a pod sandbox to run but first I had to do the following:

# docker pull kubernetes/pause
# mkdir -p /var/lib/ocid/graph/vfs/pause
# docker export $(docker create kubernetes/pause) | tar -C /var/lib/ocid/graph/vfs/pause -xvf -

# create a config.json for the sandbox

Signed-off-by: Antonio Murdaca <runcom@redhat.com>
Signed-off-by: Antonio Murdaca <runcom@redhat.com>
Signed-off-by: Antonio Murdaca <runcom@redhat.com>
@mrunalp
Copy link
Member

mrunalp commented Sep 17, 2016

@runcom Yes, we need to create the sandbox manually. I'll create an issue to track that.

@mrunalp
Copy link
Member

mrunalp commented Sep 17, 2016

LGTM

@mrunalp mrunalp merged commit 6007176 into cri-o:master Sep 17, 2016
@runcom runcom deleted the fix2 branch September 17, 2016 15:02
surajssd pushed a commit to surajssd/cri-o that referenced this pull request Nov 24, 2017
This should turn on handling of SELinux, NoNewPrivs, seccomp and Apparmor

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>

Closes: cri-o#15
Approved by: rhatdan
egernst pushed a commit to egernst/cri-o that referenced this pull request Nov 26, 2018
This commit adds the necessary spec files and scripts in order to be able to create
packages in OBS (Open Build System) and locally.

Fixes cri-o#15

Signed-off-by: Erick Cardona <erick.cardona.ruiz@intel.com>
Signed-off-by: Jose Carlos Venegas Munoz <jose.carlos.venegas.munoz@intel.com>
jwcesign referenced this pull request in jwcesign/cri-o May 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants