[release-1.11] server: serve streaming on localhost on a random port #1715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
size/XS
|
/test all |
|
LGTM |
|
Can we manually test and make sure that cross host oc exec/attach work fine with this? The e2e won't test it. |
|
@runcom did you manually test this so we can merge it? |
k8s-ci-robot
added
size/S
|
/test all |
|
/test e2e_fedora |
|
/test e2e |
5 similar comments
|
/test e2e |
|
/test e2e |
|
/test e2e |
|
/test e2e |
|
/test e2e |
|
/test e2e |
|
/test critest |
|
/test integration |
|
/test critest |
|
/test e2e |
|
/test all |
|
/test e2e |
runcom
force-pushed
the
stream-localhost-random-port-1.11
branch
from
fe79404
to
5574d90
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: runcom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Signed-off-by: Antonio Murdaca <runcom@redhat.com>
no harm in ignoring this error, it comes from the underlying kube stream server and we have no power on it as we don't own the listener (containerd/cri also ignores it) Signed-off-by: Antonio Murdaca <runcom@redhat.com>
runcom
force-pushed
the
stream-localhost-random-port-1.11
branch
from
5574d90
to
207ee60
Compare
|
/test all |
|
LGTM |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
same as #1714 but for
release-1.11Signed-off-by: Antonio Murdaca runcom@redhat.com
- What I did
- How I did it
- How to verify it
- Description for the changelog