Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unreachable error handling paths #1988

Merged
merged 1 commit into from Jan 5, 2019
Merged

Conversation

saschagrunert
Copy link
Member

The only error the Registrar can return within the Reserve() function is registrar.ErrNameReserved. This means the lines 620 and 642 in container_server.go were unreachable for now. I also removed the additional Get since the only reason that the reservation fails is that it is already reserved.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 28, 2018
@k8s-ci-robot
Copy link
Contributor

Hi @saschagrunert. Thanks for your PR.

I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 28, 2018
@openshift-ci-robot
Copy link

Hi @saschagrunert. Thanks for your PR.

I'm waiting for a kubernetes-sigs or openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhatdan
Copy link
Contributor

rhatdan commented Dec 28, 2018

/approve
/ok-to-test
LGTM
/test all

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 28, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 28, 2018
@saschagrunert
Copy link
Member Author

/test kata-containers

@rhatdan
Copy link
Contributor

rhatdan commented Dec 29, 2018

/test e2e_rhel

lib/container_server.go Outdated Show resolved Hide resolved
Signed-off-by: Sascha Grunert <sgrunert@suse.com>
@mrunalp
Copy link
Member

mrunalp commented Jan 2, 2019

/test all

@saschagrunert
Copy link
Member Author

/test kata-containers

1 similar comment
@mrunalp
Copy link
Member

mrunalp commented Jan 2, 2019

/test kata-containers

@mrunalp
Copy link
Member

mrunalp commented Jan 2, 2019

/test e2e_fedora

@saschagrunert
Copy link
Member Author

/test kata-containers

@saschagrunert
Copy link
Member Author

/retest

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 3, 2019

@saschagrunert: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/kata-jenkins 187f850 link /test kata-containers

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mrunalp
Copy link
Member

mrunalp commented Jan 4, 2019

/test e2e_fedora

@mrunalp mrunalp merged commit ddb5ab2 into cri-o:master Jan 5, 2019
@saschagrunert saschagrunert deleted the error-reduce branch January 5, 2019 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants