Add pkg unit tests and mock dependencies #1992
Conversation
k8s-ci-robot
added
the
size/XXL
k8s-ci-robot
added
cncf-cla: yes
needs-ok-to-test
|
Hi @saschagrunert. Thanks for your PR. I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Hi @saschagrunert. Thanks for your PR. I'm waiting for a kubernetes-sigs or openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
saschagrunert
force-pushed
the
pkg-unit-tests-and-mocks
branch
4 times, most recently
from
56e06bf
to
9b94360
Compare
|
/ok-to-test |
openshift-ci-robot
added
ok-to-test
|
/test kata-containers |
|
/retest |
|
@rhatdan I'm wondering if there anything I can do to fix the jenkins error |
|
I think @sameo reported that they were working to fix the kata-containers issues. |
|
/test kata-containers |
saschagrunert
force-pushed
the
pkg-unit-tests-and-mocks
branch
from
9b94360
to
bb4ed9b
Compare
|
/test all |
|
@saschagrunert, the kata tests are flaky, so we can ignore them (for now). |
|
Okay cool, I just rebased to the latest master to see if everything works as intended. |
saschagrunert
force-pushed
the
pkg-unit-tests-and-mocks
branch
2 times, most recently
from
26d8e48
to
980de65
Compare
|
During my latest rebase I had to add two new test cases for the latest Please have a look again |
Awesome, thanks! Will have a look now. |
|
I'm having a look at this today! @saschagrunert sorry if it took so long but great work, much appreciated! |
|
/test all |
|
/test e2e_features_rhel |
|
/test e2e_rhel |
|
@runcom I don't want to put the pressure to high so see this as a friendly ping :) |
|
Yes! No worry for the ping, just got home from conference (on the train home actually lol), this will be the week we'll merge this no worry :) |
This commit adds mocking capabilities via gomock and includes unit tests for the `pkg` package of cri-o. Signed-off-by: Sascha Grunert <sgrunert@suse.com>
saschagrunert
force-pushed
the
pkg-unit-tests-and-mocks
branch
from
980de65
to
c2ac97c
Compare
|
/test all |
|
/test e2e_rhel |
|
@runcom I rebased on top of the latest master including the vendoring changes. I also added the whitelist for gomock. In the end it seems that some packages get removed nevertheless (see diff). |
|
/test e2e_fedora |
|
/retest |
|
@saschagrunert I intend to make a final pass and get this in tomorrow. |
That would be really awesome, thank you very much! |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrunalp, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This commit adds mocking capabilities via gomock and includes unit tests
for the
pkgpackage of cri-o.