Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.13] config: Add config options for setting grpc msg size max #2033

Merged
merged 1 commit into from Jan 24, 2019
Merged

[1.13] config: Add config options for setting grpc msg size max #2033

merged 1 commit into from Jan 24, 2019

Conversation

mrunalp
Copy link
Member

@mrunalp mrunalp commented Jan 24, 2019

Signed-off-by: Mrunal Patel mrunalp@gmail.com

@runcom @giuseppe ptal.

@mrunalp
config: Add config options for setting grpc msg size max
a24c593 
Signed-off-by: Mrunal Patel <mrunalp@gmail.com>
@mrunalp mrunalp requested a review from runcom as a code owner January 24, 2019 01:14
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 24, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes labels Jan 24, 2019
@mrunalp
Copy link
Member Author

mrunalp commented Jan 24, 2019

/test all

@rhatdan
Copy link
Contributor

rhatdan commented Jan 24, 2019

LGTM

@runcom
Copy link
Member

runcom commented Jan 24, 2019

/retest

@runcom
Copy link
Member

runcom commented Jan 24, 2019

Kata looks broken 🤔

@mrunalp
Copy link
Member Author

mrunalp commented Jan 24, 2019

/test e2e_rhel

@mrunalp
Copy link
Member Author

mrunalp commented Jan 24, 2019

@sboeuf @chavafg Kata isn't getting triggered.

@chavafg
Copy link
Contributor

chavafg commented Jan 24, 2019

I see ci/kata-jenkins result in the job list below.
here is the log of this job: http://jenkins.katacontainers.io/job/kata-containers-crio-PR/585/

@mrunalp mrunalp added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2019
@k8s-ci-robot k8s-ci-robot merged commit 2f5123f into cri-o:release-1.13 Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runcom runcom Awaiting requested review from runcom runcom is a code owner

@giuseppe giuseppe Awaiting requested review from giuseppe

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mrunalp @k8s-ci-robot @rhatdan @runcom @chavafg