Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Sync vendor and add validation #2041

Closed
wants to merge 1 commit into from

Conversation

runcom
Copy link
Member

@runcom runcom commented Jan 29, 2019

Signed-off-by: Antonio Murdaca runcom@linux.com

- What I did

  • sync up the vendor tree
  • pin versions in vendor.conf to have deterministic vndr runs
  • removed the PKG env from make vendor; we want to run them all to have determinism
  • add validation to the vendor tree in the CI

- How I did it

- How to verify it

- Description for the changelog

x
Signed-off-by: Antonio Murdaca <runcom@linux.com>
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 29, 2019
@runcom runcom requested a review from mrunalp as a code owner January 29, 2019 13:38
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: runcom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 29, 2019
@runcom
Copy link
Member Author

runcom commented Jan 29, 2019

currently blocked with cri-o/ocicni#12 (comment)

@vrothberg
Copy link
Member

vrothberg commented Mar 13, 2019

@mrunalp @runcom, I think we can close this PR in favour of #2124

@umohnani8
Copy link
Member

Closing in favour of #2124

@umohnani8 umohnani8 closed this Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants