Update lint to use golangci-lint

[saschagrunert]

This PR switches from the deprecated gometalinter to golangci-lint, which should provide additional (fast) linting possiblities for the future.

The currently disabled linters could be enabled later on (including their fixes).

[k8s-ci-robot]

Hi @saschagrunert. Thanks for your PR.

I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

Hi @saschagrunert. Thanks for your PR.

I'm waiting for a kubernetes-sigs or openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[haircommander]

/ok-to-test

[codecov-io]

Codecov Report

Merging #2137 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2137   +/-   ##
=======================================
  Coverage   29.29%   29.29%           
=======================================
  Files          72       72           
  Lines        6520     6520           
=======================================
  Hits         1910     1910           
  Misses       4505     4505           
  Partials      105      105

[saschagrunert]

/test e2e_rhel

[mrunalp]

/approve

[mrunalp]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrunalp, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mrunalp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mrunalp]

Thanks for the PR :)