Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate CRI-O CLI man page during build #2953

Merged
merged 1 commit into from Nov 18, 2019
Merged

Generate CRI-O CLI man page during build #2953

merged 1 commit into from Nov 18, 2019

Conversation

saschagrunert
Copy link
Member

The information from the crio.8 man page have been transferred to the
CLI, which will now auto-generate the man/markdown documentation.

We now add an indicator that the CLI man pages get autogenerated so we
should not edit the markdown file directly.

@openshift-ci-robot openshift-ci-robot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Nov 7, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 7, 2019
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 7, 2019
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 7, 2019
@saschagrunert
Copy link
Member Author

/retest

TomSweeneyRedHat
TomSweeneyRedHat reviewed Nov 7, 2019
View reviewed changes
cmd/crio/config.go Outdated Show resolved Hide resolved
TomSweeneyRedHat
TomSweeneyRedHat reviewed Nov 7, 2019
View reviewed changes
cmd/crio/main.go Outdated Show resolved Hide resolved
TomSweeneyRedHat
TomSweeneyRedHat reviewed Nov 7, 2019
View reviewed changes
docs/crio.8.md Outdated Show resolved Hide resolved
@saschagrunert
Copy link
Member Author

/retest

1 similar comment
@rhatdan
Copy link
Contributor

rhatdan commented Nov 8, 2019

/retest

@saschagrunert
Generate CI-O CLI man page during build
7fcd736 
The information from the crio.8 man page have been transferred to the
CLI, which will now auto-generate the man/markdown documentation.

We now add an indicator that the CLI man pages get autogenerated so we
should not edit the markdown file directly.

Signed-off-by: Sascha Grunert <sgrunert@suse.com>
@saschagrunert
Copy link
Member Author

/retest

@rhatdan
Copy link
Contributor

rhatdan commented Nov 16, 2019

/test integration_rhel

@TomSweeneyRedHat
Copy link
Contributor

LGTM and happy green test buttons

@saschagrunert saschagrunert changed the title Generate CI-O CLI man page during build Generate CRI-O CLI man page during build Nov 16, 2019
@haircommander
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. labels Nov 17, 2019
@saschagrunert
Copy link
Member Author

/retest

4 similar comments
@saschagrunert
Copy link
Member Author

/retest

@saschagrunert
Copy link
Member Author

/retest

@saschagrunert
Copy link
Member Author

/retest

@saschagrunert
Copy link
Member Author

/retest

@rhatdan
Copy link
Contributor

rhatdan commented Nov 18, 2019

/test integration_rhel

@openshift-merge-robot openshift-merge-robot merged commit e382065 into cri-o:master Nov 18, 2019
@openshift-ci-robot openshift-ci-robot mentioned this pull request Dec 3, 2019
Closed
@openshift-ci-robot openshift-ci-robot mentioned this pull request Apr 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomSweeneyRedHat TomSweeneyRedHat TomSweeneyRedHat left review comments

@mrunalp mrunalp Awaiting requested review from mrunalp

@runcom runcom Awaiting requested review from runcom

@giuseppe giuseppe Awaiting requested review from giuseppe

@sameo sameo Awaiting requested review from sameo

@sboeuf sboeuf Awaiting requested review from sboeuf

Assignees

@haircommander haircommander

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@saschagrunert @openshift-ci-robot @rhatdan @TomSweeneyRedHat @haircommander @openshift-merge-robot