Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: move readonly_rootfs and privileged to correct place #3381

Merged
merged 1 commit into from Mar 19, 2020
Merged

test: move readonly_rootfs and privileged to correct place #3381

merged 1 commit into from Mar 19, 2020

Conversation

haircommander
Copy link
Member

@haircommander haircommander commented Mar 9, 2020 •
edited

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

fixes up the integration tests by correctly putting readonly_rootfs and privileged bools in correct place (As well as dropping privilege where it's clearly not needed)

(carrying #2992)

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

@codecov
Copy link

codecov bot commented Mar 9, 2020 •
edited

Codecov Report

Merging #3381 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3381   +/-   ##
=======================================
  Coverage   43.85%   43.85%           
=======================================
  Files          94       94           
  Lines        7700     7700           
=======================================
  Hits         3377     3377           
  Misses       4024     4024           
  Partials      299      299

@openshift-ci-robot openshift-ci-robot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 9, 2020
@haircommander
Copy link
Member Author

/test integration

@haircommander
Copy link
Member Author

/test kata

@haircommander
Copy link
Member Author

/retest

saschagrunert
saschagrunert approved these changes Mar 10, 2020
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2020
@haircommander
Copy link
Member Author

/retest

@haircommander
test: move readonly_rootfs and privileged to correct place
7615871 
as well as drop privilege from test cases that clearly didn't need it

Signed-off-by: Peter Hunt <pehunt@redhat.com>
@haircommander
Copy link
Member Author

PTAL @umohnani8 @mrunalp @nalind @rhatdan

@haircommander
Copy link
Member Author

/test kata

@umohnani8
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 19, 2020
@umohnani8
Copy link
Member

/retest

1 similar comment
@haircommander
Copy link
Member Author

/retest

@haircommander
Copy link
Member Author

failure is the segfault fixed in #3425

/retest

@openshift-merge-robot openshift-merge-robot merged commit a501c11 into cri-o:master Mar 19, 2020
@haircommander haircommander mentioned this pull request Mar 20, 2020
Closed
@openshift-ci-robot openshift-ci-robot mentioned this pull request Mar 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@mrunalp mrunalp Awaiting requested review from mrunalp

@runcom runcom Awaiting requested review from runcom

Assignees

@umohnani8 umohnani8

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@haircommander @openshift-ci-robot @umohnani8 @saschagrunert @openshift-merge-robot