Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update installation steps for CentOS #3560

Merged
merged 1 commit into from Apr 17, 2020
Merged

Update installation steps for CentOS #3560

merged 1 commit into from Apr 17, 2020

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented Apr 13, 2020

Fixes: gh#3495

Following up on pr#3514 and gh#3495, it seemed better
to create a separate OBS sub-project for each
major.minor version like CentOS SIGs did.

Signed-off-by: Lokesh Mandvekar lsm5@fedoraproject.org

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Updates the installation steps for centos. With the new setup, users don't need to explicitly include the major.minor versions in the package name.

Which issue(s) this PR fixes:

Fixes #3495

Special notes for your reviewer:

None.

Does this PR introduce a user-facing change?

None

Fixes: gh#3495

Following up on pr#3514 and gh#3495, it seemed better
to create a separate OBS sub-project for each
major.minor version like CentOS SIGs did.

Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
@openshift-ci-robot openshift-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Apr 13, 2020
@codecov
Copy link

codecov bot commented Apr 13, 2020

Codecov Report

Merging #3560 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3560   +/-   ##
=======================================
  Coverage   43.78%   43.78%           
=======================================
  Files         101      101           
  Lines        7744     7744           
=======================================
  Hits         3391     3391           
  Misses       4056     4056           
  Partials      297      297           

@TomSweeneyRedHat
Copy link
Contributor

Changes LGTM, but I don't have a vm to test on atm.

@lsm5
Copy link
Member Author

lsm5 commented Apr 13, 2020

Changes LGTM, but I don't have a vm to test on atm.

should work on a centos container too. vm not necessary.

@haircommander
Copy link
Member

/retest
/approve

@openshift-ci-robot
Copy link

@haircommander: The /retest command does not accept any targets.
The following commands are available to trigger jobs:

  • /test kata-containers
  • /test ami_fedora
  • /test ami_rhel
  • /test critest_fedora
  • /test critest_rhel
  • /test e2e_crun
  • /test e2e_cgroupv2
  • /test e2e_features_fedora
  • /test e2e_features_rhel
  • /test e2e_fedora
  • /test e2e_rhel
  • /test integration_crun
  • /test integration_cgroupv2
  • /test integration_fedora
  • /test integration_rhel

Use /test all to run all jobs.

In response to this:

/retest
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci-robot
Copy link

@haircommander: The /retest command does not accept any targets.
The following commands are available to trigger jobs:

  • /test kata-containers
  • /test ami_fedora
  • /test ami_rhel
  • /test critest_fedora
  • /test critest_rhel
  • /test e2e_crun
  • /test e2e_cgroupv2
  • /test e2e_features_fedora
  • /test e2e_features_rhel
  • /test e2e_fedora
  • /test e2e_rhel
  • /test integration_crun
  • /test integration_cgroupv2
  • /test integration_fedora
  • /test integration_rhel

Use /test all to run all jobs.

In response to this:

/retest
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2020
@haircommander
Copy link
Member

/retest

@mrunalp
Copy link
Member

mrunalp commented Apr 17, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, lsm5, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [haircommander,mrunalp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

crio package not available in CentOS 7 repository
6 participants