Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.16] bump c/storage to 01ee1656d5522870 #3589

Merged
merged 1 commit into from Apr 27, 2020

Conversation

haircommander
Copy link
Member

What type of PR is this?

/kind dependency-change

What this PR does / why we need it:

bumps c/storage to crio-release-1.17 which contains containers/storage@01ee165, as we saw


Apr 15 13:44:43 ip-10-0-129-128.us-east-2.compute.internal crio[70396]: panic: attempted to update last-writer in lockfile without the write lock
Apr 15 13:44:43 ip-10-0-129-128.us-east-2.compute.internal crio[70396]: goroutine 135 [running]:
Apr 15 13:44:43 ip-10-0-129-128.us-east-2.compute.internal crio[70396]: panic(0x560e8b171000, 0x560e8b4bc160)

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

fix containers/storage panic

to pick up a fix preventing a panic

Signed-off-by: Peter Hunt <pehunt@redhat.com>
@openshift-ci-robot openshift-ci-robot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/dependency-change Categorizes issue or PR as related to changing dependencies labels Apr 15, 2020
@openshift-ci-robot openshift-ci-robot requested review from umohnani8, nalind and saschagrunert and removed request for umohnani8 April 15, 2020 19:54
@haircommander
Copy link
Member Author

/retest

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2020
@mrunalp
Copy link
Member

mrunalp commented Apr 15, 2020

@umohnani8 @nalind ptal

@codecov
Copy link

codecov bot commented Apr 15, 2020

Codecov Report

Merging #3589 into release-1.16 will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           release-1.16    #3589   +/-   ##
=============================================
  Coverage         45.85%   45.85%           
=============================================
  Files                87       87           
  Lines              7567     7567           
=============================================
  Hits               3470     3470           
  Misses             3791     3791           
  Partials            306      306           

@haircommander
Copy link
Member Author

/retest

1 similar comment
@mrunalp
Copy link
Member

mrunalp commented Apr 16, 2020

/retest

@umohnani8
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. labels Apr 16, 2020
@haircommander
Copy link
Member Author

/test launch-aws
/test e2e-aws

@mrunalp
Copy link
Member

mrunalp commented Apr 21, 2020

/retest

@TomSweeneyRedHat
Copy link
Contributor

LGTM assuming happy tests

@mrunalp
Copy link
Member

mrunalp commented Apr 27, 2020

/lgtm

@mrunalp
Copy link
Member

mrunalp commented Apr 27, 2020

/retest

@openshift-ci-robot
Copy link

@haircommander: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/openshift-jenkins/integration_crun_cgroupv2 0f35e90 link /test integration_cgroupv2
ci/prow/e2e-aws 0f35e90 link /test e2e-aws
ci/prow/launch-aws 0f35e90 link /test launch-aws
ci/prow/images 0f35e90 link /test images
ci/openshift-jenkins/e2e_crun_cgroupv2 0f35e90 link /test e2e_cgroupv2
ci/openshift-jenkins/e2e_features_fedora 0f35e90 link /test e2e_features_fedora
ci/openshift-jenkins/e2e_crun 0f35e90 link /test e2e_crun

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mrunalp mrunalp merged commit 639ad42 into cri-o:release-1.16 Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/dependency-change Categorizes issue or PR as related to changing dependencies lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants