Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.18] Add sandbox verbose info #3820

Merged
merged 3 commits into from Jun 3, 2020
Merged

[release-1.18] Add sandbox verbose info #3820

merged 3 commits into from Jun 3, 2020

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #3819

/assign mrunalp

Return pod image, pid and spec in sandbox_status CRI verbose mode

@mrunalp
Store pause image information for a pod
0e5def6 
Signed-off-by: Mrunal Patel <mrunalp@gmail.com>
@mrunalp
Return verbose information for a pod
b789a54 
We return pod pause image, pid and runtime spec
when verbose is set for pod sandbox status CRI
call.

Signed-off-by: Mrunal Patel <mrunalp@gmail.com>
@mrunalp
test: Add a test for pod pause image
a05cf7a 
Test that the pod pause image matches the pause_image
configured in crio.conf

Signed-off-by: Mrunal Patel <mrunalp@gmail.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 3, 2020
Merged
@openshift-ci-robot openshift-ci-robot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jun 3, 2020
@codecov
Copy link

codecov bot commented Jun 3, 2020

Codecov Report

Merging #3820 into release-1.18 will decrease coverage by 0.07%.
The diff coverage is 14.28%.

@@               Coverage Diff                @@
##           release-1.18    #3820      +/-   ##
================================================
- Coverage         40.51%   40.44%   -0.08%     
================================================
  Files               105      105              
  Lines              8611     8630      +19     
================================================
+ Hits               3489     3490       +1     
- Misses             4811     4828      +17     
- Partials            311      312       +1

@haircommander
Copy link
Member

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 3, 2020
@haircommander
Copy link
Member

/retest

saschagrunert
saschagrunert approved these changes Jun 3, 2020
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, openshift-cherrypick-robot, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [haircommander,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, openshift-cherrypick-robot, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [haircommander,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mrunalp
Copy link
Member

mrunalp commented Jun 3, 2020

/test kata-containers

@openshift-merge-robot openshift-merge-robot merged commit ea514d3 into cri-o:release-1.18 Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@runcom runcom Awaiting requested review from runcom runcom is a code owner

@sameo sameo Awaiting requested review from sameo

@vrothberg vrothberg Awaiting requested review from vrothberg

Assignees

@mrunalp mrunalp

@haircommander haircommander

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@openshift-cherrypick-robot @haircommander @openshift-ci-robot @mrunalp @saschagrunert @openshift-merge-robot