New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to updated version of creack/pty #4192
Switch to updated version of creack/pty #4192
Conversation
Looks like there is a regression which does not allow to run exec any more when compiling CRI-O with newer go versions. Signed-off-by: Sascha Grunert <sgrunert@suse.com>
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## release-1.18 #4192 +/- ##
=============================================
Coverage 40.71% 40.71%
=============================================
Files 106 106
Lines 8758 8758
=============================================
Hits 3566 3566
Misses 4875 4875
Partials 317 317 |
/retest |
LGTM |
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, mrunalp, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/retest |
/test integration_fedora |
/retest |
@saschagrunert: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Looks like there is a regression which does not allow to run exec any
more when compiling CRI-O with newer go versions.
Which issue(s) this PR fixes:
Might fix #4189, kubernetes/kubernetes#94750
Related to #4110
Backport of #4111
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?