Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to updated version of creack/pty #4192

Merged

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Sep 14, 2020

What type of PR is this?

/kind bug

What this PR does / why we need it:

Looks like there is a regression which does not allow to run exec any
more when compiling CRI-O with newer go versions.

Which issue(s) this PR fixes:

Might fix #4189, kubernetes/kubernetes#94750
Related to #4110
Backport of #4111

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

- Fixed regression where it was not able to run exec any more when compiling CRI-O with newer go versions

Looks like there is a regression which does not allow to run exec any
more when compiling CRI-O with newer go versions.

Signed-off-by: Sascha Grunert <sgrunert@suse.com>
@openshift-ci-robot openshift-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 14, 2020
@saschagrunert
Copy link
Member Author

/retest

Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Sep 14, 2020

Codecov Report

Merging #4192 into release-1.18 will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           release-1.18    #4192   +/-   ##
=============================================
  Coverage         40.71%   40.71%           
=============================================
  Files               106      106           
  Lines              8758     8758           
=============================================
  Hits               3566     3566           
  Misses             4875     4875           
  Partials            317      317           

@saschagrunert
Copy link
Member Author

/retest

@TomSweeneyRedHat
Copy link
Contributor

LGTM
assuming happy tests

@saschagrunert
Copy link
Member Author

/retest

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, mrunalp, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [giuseppe,mrunalp,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mrunalp
Copy link
Member

mrunalp commented Sep 14, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 14, 2020
@saschagrunert
Copy link
Member Author

/retest

@saschagrunert
Copy link
Member Author

/test integration_fedora

@saschagrunert
Copy link
Member Author

/retest

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 15, 2020

@saschagrunert: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/openshift-jenkins/integration_crun_cgroupv2 d082771 link /test integration_cgroupv2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit ae4ef7b into cri-o:release-1.18 Sep 15, 2020
@saschagrunert saschagrunert deleted the release-1.18-pty branch September 15, 2020 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants