Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make CNI setup instructions a bit more clear and fix nits #4364

Merged
merged 2 commits into from Nov 18, 2020
Merged

Make CNI setup instructions a bit more clear and fix nits #4364

merged 2 commits into from Nov 18, 2020

Conversation

markusthoemmes
Copy link
Contributor

Signed-off-by: Markus Thömmes markusthoemmes@me.com

What type of PR is this?

/kind documentation

What this PR does / why we need it:

This calls out explicitly how to install the example CNI configurations (and also actually call out that the user has to do something here).

In addition to that this adds a few missing full stops and slightly alters the wording around the CNI version used, as the tutorial is explicitly not using the version at master.

Does this PR introduce a user-facing change?

None

@markusthoemmes
Make CNI setup instructions a bit more clear and fix nits
fedd00c 
This calls out explicitly how to install the example CNI configurations (and also actually call out that the user has to do something here).

In addition to that this adds a few missing full stops and slightly alters the wording around the CNI version used, as the tutorial is explicitly **not** using the version at master.

Signed-off-by: Markus Thömmes <markusthoemmes@me.com>
@openshift-ci-robot openshift-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/documentation Categorizes issue or PR as related to documentation. labels Nov 12, 2020
@openshift-ci-robot
Copy link

Hi @markusthoemmes. Thanks for your PR.

I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 12, 2020
@codecov
Copy link

codecov bot commented Nov 12, 2020 •
edited

Codecov Report

Merging #4364 (329ccba) into master (48ee902) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4364   +/-   ##
=======================================
  Coverage   39.29%   39.29%           
=======================================
  Files         112      112           
  Lines        8835     8835           
=======================================
  Hits         3472     3472           
  Misses       4977     4977           
  Partials      386      386

@haircommander
Copy link
Member

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 12, 2020
haircommander
haircommander reviewed Nov 12, 2020
View reviewed changes
contrib/cni/README.md

Download the `CNI` plugins source tree:

```bash
git clone https://github.com/containernetworking/plugins
cd plugins
git checkout v0.8.1
git checkout v0.8.7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be honest, I am not sure we test against this and we should probably check it works before changing it 🙃

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well the main go.mod has this version :).

@openshift-ci-robot openshift-ci-robot added dco-signoff: no Indicates the PR's author has not DCO signed all their commits. and removed dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Nov 12, 2020
@markusthoemmes
Add wrongly removed word
329ccba 
Signed-off-by: Markus Thömmes <markusthoemmes@me.com>
@openshift-ci-robot openshift-ci-robot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Nov 12, 2020
@umohnani8
Copy link
Member

LGTM
/retest

TomSweeneyRedHat
TomSweeneyRedHat reviewed Nov 12, 2020
View reviewed changes
Copy link
Contributor

@TomSweeneyRedHat TomSweeneyRedHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
assuming happy tests.

@umohnani8
Copy link
Member

/retest
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2020
@haircommander
Copy link
Member

/retest

1 similar comment
@markusthoemmes
Copy link
Contributor Author

/retest

@markusthoemmes
Copy link
Contributor Author

Anything left to do here? Should I go revert the version bump?

@haircommander
Copy link
Member

nah, we should be compatible, and if we're not, we should hear about it and fix it 😄

/approve

is all you're missing.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 17, 2020
@haircommander
Copy link
Member

/retest

1 similar comment
@haircommander
Copy link
Member

/retest

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, markusthoemmes, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [haircommander,mrunalp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markusthoemmes
Copy link
Contributor Author

/retest

@markusthoemmes
Copy link
Contributor Author

/retest

Almost there!

@openshift-merge-robot openshift-merge-robot merged commit ae6220f into cri-o:master Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haircommander haircommander haircommander left review comments

@TomSweeneyRedHat TomSweeneyRedHat TomSweeneyRedHat left review comments

@mrunalp mrunalp mrunalp approved these changes

@runcom runcom Awaiting requested review from runcom

@umohnani8 umohnani8 Awaiting requested review from umohnani8

Assignees

@umohnani8 umohnani8

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@markusthoemmes @openshift-ci-robot @haircommander @umohnani8 @mrunalp @TomSweeneyRedHat @openshift-merge-robot