Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crio.service: Request to be run before kubelet.service #4443

Merged
merged 1 commit into from Mar 4, 2021
Merged

crio.service: Request to be run before kubelet.service #4443

merged 1 commit into from Mar 4, 2021

Conversation

haircommander
Copy link
Member

What type of PR is this?

/kind api-change
/kind bug
/kind ci
/kind cleanup
/kind dependency-change
/kind deprecation
/kind design

/kind documentation

/kind failing-test
/kind feature
/kind flake
/kind other

What this PR does / why we need it:

on top of making logical sense (kubelet can't do anything without crio running), this also avoids odd situations
where the kubelet can't register an imagefs without crio being up first

Signed-off-by: Peter Hunt pehunt@redhat.com

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

The installed cri-o.service file now attempts to be run before kubelet.service

@haircommander
crio.service: Request to be run before kubelet.service
2937c07 
on top of making logical sense (kubelet can't do anything without crio running), this also avoids odd situations
where the kubelet can't register an imagefs without crio being up first

Signed-off-by: Peter Hunt <pehunt@redhat.com>
@openshift-ci-robot openshift-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Dec 17, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2020
@haircommander
Copy link
Member Author

fixes #4437

@codecov
Copy link

codecov bot commented Dec 17, 2020

Codecov Report

Merging #4443 (2937c07) into master (6ee8d68) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4443   +/-   ##
=======================================
  Coverage   40.09%   40.09%           
=======================================
  Files         116      116           
  Lines        9378     9378           
=======================================
  Hits         3760     3760           
  Misses       5212     5212           
  Partials      406      406

saschagrunert
saschagrunert approved these changes Jan 11, 2021
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haircommander
Copy link
Member Author

@mrunalp @giuseppe @umohnani8 @kolyshkin ptal

giuseppe
giuseppe approved these changes Jan 11, 2021
View reviewed changes
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, haircommander, mrunalp, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [giuseppe,haircommander,mrunalp,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mrunalp
Copy link
Member

mrunalp commented Mar 4, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2021
@openshift-ci-robot
Copy link

@haircommander: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/kata-jenkins 2937c07 link /test kata-containers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@haircommander
Copy link
Member Author

/test integration_crun
/override ci/kata-jenkins

@openshift-ci-robot
Copy link

@haircommander: Overrode contexts on behalf of haircommander: ci/kata-jenkins

In response to this:

/test integration_crun
/override ci/kata-jenkins

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 4, 2021 •
edited

@haircommander: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/openshift-jenkins/integration_crun_cgroupv2 2937c07 link /test integration_cgroupv2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 342d049 into cri-o:master Mar 4, 2021
@haircommander
Copy link
Member Author

/cherry-pick release-1.20

@haircommander
Copy link
Member Author

/cherry-pick release-1.19

@haircommander
Copy link
Member Author

/cherry-pick release-1.18

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 8, 2021
Merged
@openshift-cherrypick-robot
Copy link

@haircommander: new pull request created: #4635

In response to this:

/cherry-pick release-1.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@haircommander: new pull request created: #4636

In response to this:

/cherry-pick release-1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 8, 2021
Merged
@openshift-cherrypick-robot
Copy link

@haircommander: new pull request created: #4637

In response to this:

/cherry-pick release-1.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 8, 2021
Merged
@haircommander haircommander mentioned this pull request Mar 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp mrunalp approved these changes

@giuseppe giuseppe giuseppe approved these changes

@saschagrunert saschagrunert saschagrunert approved these changes

@runcom runcom Awaiting requested review from runcom

@nalind nalind Awaiting requested review from nalind

@sameo sameo Awaiting requested review from sameo

Assignees

@mrunalp mrunalp

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@haircommander @openshift-ci-robot @mrunalp @openshift-cherrypick-robot @giuseppe @saschagrunert @openshift-merge-robot