server: mount cgroup with rslave

[giuseppe]

even when running as privileged container, prevent cgroup mounts to be
propagated to the host as it could cause errors when running with
rshared and systemd inside of the container.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1903553

Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com

What type of PR is this?

/kind bug

What this PR does / why we need it:

fixes https://bugzilla.redhat.com/show_bug.cgi?id=1903553

Which issue(s) this PR fixes:

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1903553

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fix running privileged systemd containers with bidirectional mounts

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [giuseppe]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[haircommander]

LGTM

[codecov]

Codecov Report

Merging #4575 (0778972) into master (c787156) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master    #4575   +/-   ##
=======================================
  Coverage   40.44%   40.44%           
=======================================
  Files         115      115           
  Lines        9385     9385           
=======================================
  Hits         3796     3796           
  Misses       5161     5161           
  Partials      428      428           

[openshift-ci]

@giuseppe: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-gcp	0778972	link	/test e2e-gcp
ci/prow/e2e-agnostic	0778972	link	/test e2e-agnostic

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[giuseppe]

@haircommander @mrunalp PTAL

[mrunalp]

/lgtm

[giuseppe]

/cherry-pick release-1.19
/cherry-pick release-1.20

[openshift-cherrypick-robot]

@giuseppe: #4575 failed to apply on top of branch "release-1.19":

Applying: server: mount cgroup with rslave
Using index info to reconstruct a base tree...
M	server/container_create_linux.go
Falling back to patching base and 3-way merge...
Auto-merging server/container_create_linux.go
CONFLICT (content): Merge conflict in server/container_create_linux.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 server: mount cgroup with rslave
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.19
/cherry-pick release-1.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[giuseppe]

/cherry-pick release-1.20

[openshift-cherrypick-robot]

@giuseppe: new pull request created: #4577

In response to this:

/cherry-pick release-1.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.