Remove .gitattributes files from vendor directory #4824
Conversation
openshift-ci-robot
added
release-note-none
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
.gitattributes files containing `export-subst` will cause that the source code tarball contents will change when the short commit does. To avoid that we now ignore .gitattributes files from the vendor directory. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert
force-pushed
the
vendor-gitattributes
branch
from
4f6b562
to
dbca042
Compare
Codecov Report
@@ Coverage Diff @@
## master #4824 +/- ##
=======================================
Coverage 43.00% 43.00%
=======================================
Files 107 107
Lines 9792 9792
=======================================
Hits 4211 4211
Misses 5131 5131
Partials 450 450 |
|
/retest |
|
@saschagrunert: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/override ci/prow/e2e-gcp |
|
@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/e2e-gcp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
.gitattributes files containing
export-substwill cause that thesource code tarball contents will change when the short commit does. To
avoid that we now ignore .gitattributes files from the vendor directory.
Which issue(s) this PR fixes:
Fixes #4820
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?