Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.21] Fix CI #4961

Merged
merged 1 commit into from Jun 6, 2021
Merged

[1.21] Fix CI #4961

merged 1 commit into from Jun 6, 2021

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Jun 2, 2021 •
edited

What type of PR is this?

/kind failing-test

What this PR does / why we need it:

This should make the CI green again on 1.21.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

Updated static binary bundle crun version to v0.20

@openshift-ci openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. labels Jun 2, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 2, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested a review from giuseppe June 2, 2021 10:53
@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jun 2, 2021
@saschagrunert
Copy link
Member Author

/test critest_fedora

1 similar comment
@saschagrunert
Copy link
Member Author

/test critest_fedora

@codecov
Copy link

codecov bot commented Jun 2, 2021 •
edited

Codecov Report

Merging #4961 (9b6f4e5) into release-1.21 (88c7c73) will increase coverage by 3.04%.
The diff coverage is 48.37%.

@@               Coverage Diff                @@
##           release-1.21    #4961      +/-   ##
================================================
+ Coverage         40.17%   43.22%   +3.04%     
================================================
  Files               115      107       -8     
  Lines              9311     9847     +536     
================================================
+ Hits               3741     4256     +515     
+ Misses             5154     5141      -13     
- Partials            416      450      +34

@saschagrunert
Fix CI
9b6f4e5 
Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@saschagrunert
Copy link
Member Author

/retest

@saschagrunert
Copy link
Member Author

@haircommander PTAL, GitHub actions are green again

@haircommander
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 3, 2021
@saschagrunert
Copy link
Member Author

/test e2e_fedora

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@haircommander
Copy link
Member

/hold

until containers/conmon#268 merges

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 3, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 3, 2021 •
edited

@saschagrunert: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/openshift-jenkins/e2e_crun_cgroupv2 9b6f4e5 link /test e2e_cgroupv2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@haircommander
Copy link
Member

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 4, 2021
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit e1bc46b into cri-o:release-1.21 Jun 6, 2021
@saschagrunert saschagrunert deleted the release-1.21-ci branch June 7, 2021 06:44
@openshift-ci openshift-ci bot mentioned this pull request Jun 8, 2021
Closed
@openshift-ci openshift-ci bot mentioned this pull request Mar 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@runcom runcom Awaiting requested review from runcom runcom is a code owner

@giuseppe giuseppe Awaiting requested review from giuseppe

Assignees

@haircommander haircommander

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@saschagrunert @haircommander @openshift-bot @openshift-merge-robot