[ON HOLD] *: update kube vendor to latest master #510

runcom · 2017-05-14T13:32:13Z

Close #509

Signed-off-by: Antonio Murdaca runcom@redhat.com

runcom · 2017-05-14T13:32:40Z

@mrunalp @sameo PTAL

runcom · 2017-05-14T15:45:08Z

@sameo CRI has removed netns path exposure from sandbox status, therefore network tests are now failing.

sameo · 2017-05-15T08:07:17Z

@runcom I'll try to fix those in the next 2 days. I'm travelling this week, I'll keep you posted.

runcom · 2017-05-15T08:09:45Z

@sameo no worry, I'll try to replace calls to netns exec with a simple container exec followed by an ip (or ifconfig) command to get container IP and verify tests.

runcom · 2017-05-15T08:56:19Z

@sameo I fixed them, this should be all green now

sameo · 2017-05-15T09:04:44Z

test/network.bats


-	check_pod_cidr $pod_id
+	check_pod_cidr $ctr_id



you need a cleanup_ctrs call here.

sameo · 2017-05-15T09:04:55Z

test/network.bats


-	ping_pod $pod_id
+	ping_pod $ctr_id



sameo · 2017-05-15T09:05:11Z

test/network.bats

 	[ "$status" -eq 0 ]

-	ping_pod_from_pod $pod2_id $pod1_id
+	ping_pod_from_pod $ctr2_id $ctr1_id
 	[ "$status" -eq 0 ]



sameo · 2017-05-15T09:05:53Z

@runcom besides the missing ctrs cleanups, LGTM.

sameo · 2017-05-15T09:24:39Z

LGTM

TomSweeneyRedHat · 2017-05-15T11:11:25Z

cmd/ocic/container.go

@@ -10,10 +10,10 @@ import (

 	"github.com/urfave/cli"
 	"golang.org/x/net/context"
+	remocommandconsts "k8s.io/apimachinery/pkg/util/remotecommand"


Nit, and don't hold up the submit for this, but could you go back and change this variable name to "remotecommandconsts"? (Add 'te' after 'remo')

it's copy-pasted from kube, let's follow up on this so I don't have to rebase #511 again :)

That works for me.

TomSweeneyRedHat

minor nit, otherwise LGTM.

runcom · 2017-05-16T08:33:49Z

retest

runcom · 2017-05-16T08:35:46Z

all, this is rebased but I'd like to get #505 in firstly

runcom · 2017-05-17T10:59:14Z

retest

mrunalp · 2017-05-22T01:28:43Z

Needs rebase now. Let us get this one in. I want to get in one more update after this to enable sharing pid namespaces.

runcom · 2017-05-22T10:16:36Z

rebased

rh-atomic-bot · 2017-05-22T11:38:07Z

0/0 passed on RHEL - Passed.
0/0 k8s node-e2e passed on RHEL - Failed.

0/0 passed on Fedora - Passed.
0/0 k8s node-e2e passed on Fedora - Failed.

0/0 passed on CentOS - Passed.
0/0 k8s node-e2e passed on CentOS - Failed.

Log - https://aos-ci.s3.amazonaws.com/kubernetes-incubator/cri-o/crio-integration-tests-prs/336/fullresults.txt

rh-atomic-bot · 2017-05-22T13:50:40Z

54/54 passed on RHEL - Passed.
0/0 k8s node-e2e passed on RHEL - Failed.

54/54 passed on Fedora - Passed.
0/1 k8s node-e2e passed on Fedora - Failed.

54/54 passed on CentOS - Passed.
0/0 k8s node-e2e passed on CentOS - Failed.

Log - https://aos-ci.s3.amazonaws.com/kubernetes-incubator/cri-o/crio-integration-tests-prs/337/fullresults.txt

runcom · 2017-05-22T13:52:35Z

need to investigate why node-e2e aren't working with latest kube (kubelet isn't coming up). Still testing for #533 so @mrunalp if you could run node-e2e with this PR we may move this forward sooner.

mrunalp · 2017-05-22T14:04:30Z

Yeah I will run them locally.

…

On May 22, 2017, at 6:52 AM, Antonio Murdaca ***@***.***> wrote: need to investigate why node-e2e aren't working with latest kube. Still testing for #533 so @mrunalp if you could run node-e2e with this PR we may move this forward sooner. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

runcom · 2017-05-22T14:43:21Z

Yeah I will run them locally.

note that it needs you to have go1.8.1+

rh-atomic-bot · 2017-05-29T19:18:03Z

26/47 passed on RHEL - Failed.
0/0 k8s node-e2e passed on RHEL - Failed.

26/47 passed on Fedora - Failed.
120/121 k8s node-e2e passed on Fedora - Failed.

26/47 passed on CentOS - Failed.
0/0 k8s node-e2e passed on CentOS - Failed.

Log - https://aos-ci.s3.amazonaws.com/kubernetes-incubator/cri-o/crio-integration-tests-prs/378/fullresults.txt

runcom · 2017-05-29T19:50:53Z

needs rebase and fix

mrunalp · 2017-05-29T19:54:22Z

We can get this in soon. I just want us to make sure that we manually test port forward, exec, attach etc. on this once.

runcom · 2017-05-29T19:56:37Z

@mrunalp I'll run kube e2e on this branch before merging so we know port forward, exec, attach etc works fine, there are new CRI routes also in kube master, and we're behind right now

rh-atomic-bot · 2017-05-29T21:25:30Z

63/63 passed on RHEL - Passed.
0/0 k8s node-e2e passed on RHEL - Failed.

26/27 passed on Fedora - Failed.
120/121 k8s node-e2e passed on Fedora - Failed.

63/63 passed on CentOS - Passed.
0/0 k8s node-e2e passed on CentOS - Failed.

Log - https://aos-ci.s3.amazonaws.com/kubernetes-incubator/cri-o/crio-integration-tests-prs/379/fullresults.txt

runcom · 2017-05-29T21:28:06Z

oom test flaky, node-e2e is good here, need just rebase

sameo · 2017-05-30T12:56:53Z

test/helpers.bash

 function crioctl() {
 	"$OCIC_BINARY" --connect "$CRIO_SOCKET" "$@"
 }

+# Run crictl using the binary specified by $CRICTL_BINARY.
+function crictl() {


Just as a note: We probably want the crictl integration to be part of its own commit.

yep, will take care of it later this week probably.

fixed now instead :)

rh-atomic-bot · 2017-05-30T20:01:09Z

63/63 passed on RHEL - Passed.
115/121 k8s node-e2e passed on RHEL - Failed.

63/63 passed on Fedora - Passed.
119/121 k8s node-e2e passed on Fedora - Failed.

63/63 passed on CentOS - Passed.
0/0 k8s node-e2e passed on CentOS - Failed.

Log - https://aos-ci.s3.amazonaws.com/kubernetes-incubator/cri-o/crio-integration-tests-prs/390/fullresults.txt

Signed-off-by: Antonio Murdaca <runcom@redhat.com>

runcom · 2017-06-06T08:42:40Z

we need #564 before getting this in.

rh-atomic-bot · 2017-06-06T14:03:34Z

26/46 passed on RHEL - Failed.
116/121 k8s node-e2e passed on RHEL - Failed.

26/46 passed on Fedora - Failed.
120/121 k8s node-e2e passed on Fedora - Failed.

26/46 passed on CentOS - Failed.
0/0 k8s node-e2e passed on CentOS - Failed.

Log - https://aos-ci.s3.amazonaws.com/kubernetes-incubator/cri-o/crio-integration-tests-prs/433/fullresults.txt

runcom · 2017-06-06T14:06:35Z

contrib/test/crio-integration-playbook.yaml

@@ -193,6 +199,14 @@
      chdir: /root/src/github.com/opencontainers/runc
    async: 600
    poll: 10
+  - name: make crictl
+    shell: |
+      go install github.com/kubernetes-incubator/cri-tools/cmd/crictl && \


this is breaking - we need to stick version here :)

Signed-off-by: Antonio Murdaca <runcom@redhat.com>

rh-atomic-bot · 2017-06-21T11:19:10Z

0/0 passed on RHEL - Passed.
0/0 k8s node-e2e passed on RHEL - Failed.

0/0 passed on Fedora - Passed.
0/0 k8s node-e2e passed on Fedora - Failed.

0/0 passed on CentOS - Passed.
0/0 k8s node-e2e passed on CentOS - Failed.

Log - https://aos-ci.s3.amazonaws.com/kubernetes-incubator/cri-o/crio-integration-tests-prs/536/fullresults.txt

runcom · 2017-06-21T11:20:42Z

I'll rework this to update master to 1.7.x now, I'll reset kube-1.6.x branch to v1.0.0-alpha.0 also -- every 1.6.x work will go there from now on

rhatdan · 2017-07-19T19:54:23Z

@runcom Is this still being worked?

runcom · 2017-07-19T20:53:12Z

Yes, kind of, it's next on my to-do list after the registry patch

runcom · 2017-08-04T12:22:48Z

Closing in favor of #732

k8s-ci-robot added the cncf-cla: yes label May 14, 2017

runcom mentioned this pull request May 14, 2017

[DO NOT MERGE] server: implement ImageFsInfo API #511

Closed

runcom force-pushed the upgrade-kube-to-latest-master branch from f3a836b to bd9a088 Compare May 14, 2017 15:46

runcom force-pushed the upgrade-kube-to-latest-master branch from bd9a088 to 14f482a Compare May 15, 2017 08:58

sameo reviewed May 15, 2017

View reviewed changes

runcom force-pushed the upgrade-kube-to-latest-master branch from 14f482a to 73f661f Compare May 15, 2017 09:21

TomSweeneyRedHat reviewed May 15, 2017

View reviewed changes

runcom force-pushed the upgrade-kube-to-latest-master branch from 73f661f to 09d34b7 Compare May 16, 2017 08:31

runcom force-pushed the upgrade-kube-to-latest-master branch from 09d34b7 to c0b3f8c Compare May 22, 2017 10:15

runcom force-pushed the upgrade-kube-to-latest-master branch 2 times, most recently from 4e952d3 to 0b3d813 Compare May 22, 2017 11:09

runcom force-pushed the upgrade-kube-to-latest-master branch from 0b3d813 to 7dc8ea7 Compare May 22, 2017 11:53

runcom force-pushed the upgrade-kube-to-latest-master branch from dfc217a to d3763cd Compare May 29, 2017 18:27

runcom force-pushed the upgrade-kube-to-latest-master branch from d3763cd to 0c25357 Compare May 30, 2017 07:21

runcom mentioned this pull request May 30, 2017

enable RHEL k8s node-e2e tests #529

Merged

sameo reviewed May 30, 2017

View reviewed changes

runcom force-pushed the upgrade-kube-to-latest-master branch 3 times, most recently from 08f5ea3 to 01ba8fc Compare May 30, 2017 15:22

runcom force-pushed the upgrade-kube-to-latest-master branch from 01ba8fc to ae45c17 Compare May 30, 2017 20:45

*: update kube vendor to latest master

1b5a7e8

Signed-off-by: Antonio Murdaca <runcom@redhat.com>

runcom force-pushed the upgrade-kube-to-latest-master branch from ae45c17 to 7c51aef Compare June 6, 2017 08:42

runcom changed the title *: update kube vendor to latest master [ON HOLD] *: update kube vendor to latest master Jun 6, 2017

runcom commented Jun 6, 2017

View reviewed changes

*: initial wire in of crictl from cri-tools

3ec20bd

Signed-off-by: Antonio Murdaca <runcom@redhat.com>

runcom force-pushed the upgrade-kube-to-latest-master branch from 7c51aef to 3ec20bd Compare June 21, 2017 10:59

runcom mentioned this pull request Aug 4, 2017

[DO NOT MERGE, JUST TESTING]*: update kube vendor to v1.7 #732

Closed

runcom closed this Aug 4, 2017

[ON HOLD] *: update kube vendor to latest master #510

[ON HOLD] *: update kube vendor to latest master #510

Conversation

runcom commented May 14, 2017

runcom commented May 14, 2017

runcom commented May 14, 2017

sameo commented May 15, 2017

runcom commented May 15, 2017

runcom commented May 15, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sameo commented May 15, 2017

sameo commented May 15, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TomSweeneyRedHat left a comment

Choose a reason for hiding this comment

runcom commented May 16, 2017

runcom commented May 16, 2017 • edited Loading

runcom commented May 17, 2017

mrunalp commented May 22, 2017

runcom commented May 22, 2017

rh-atomic-bot commented May 22, 2017

rh-atomic-bot commented May 22, 2017

runcom commented May 22, 2017 • edited Loading

mrunalp commented May 22, 2017 via email

runcom commented May 22, 2017

rh-atomic-bot commented May 29, 2017

runcom commented May 29, 2017

mrunalp commented May 29, 2017

runcom commented May 29, 2017

rh-atomic-bot commented May 29, 2017

runcom commented May 29, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rh-atomic-bot commented May 30, 2017

runcom commented Jun 6, 2017

rh-atomic-bot commented Jun 6, 2017

Choose a reason for hiding this comment

rh-atomic-bot commented Jun 21, 2017

runcom commented Jun 21, 2017

rhatdan commented Jul 19, 2017

runcom commented Jul 19, 2017

runcom commented Aug 4, 2017

runcom commented May 16, 2017 •

edited

Loading

runcom commented May 22, 2017 •

edited

Loading