Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.22] Fix missing quantile in latency_microseconds_total metrics #5259

Merged
merged 1 commit into from Aug 30, 2021
Merged

[release-1.22] Fix missing quantile in latency_microseconds_total metrics #5259

merged 1 commit into from Aug 30, 2021

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #5258

/assign saschagrunert

Fixed missing quantile values in `container_runtime_crio_operations_latency_microseconds_total` metrics

@saschagrunert
Fix missing quantile in latency_microseconds_total metrics
d45f1f1 
The quantile has to be added manually since a couple of prometheus
client releases and we missed that. Adding an integration test to ensure
that the quantile exist in the future.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@openshift-ci openshift-ci bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Aug 27, 2021
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 27, 2021
Merged
@openshift-ci openshift-ci bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Aug 27, 2021
@codecov
Copy link

codecov bot commented Aug 27, 2021

Codecov Report

Merging #5259 (1d08bba) into release-1.22 (6becad2) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head 1d08bba differs from pull request most recent head d45f1f1. Consider uploading reports for the commit d45f1f1 to get more accurate results

@@               Coverage Diff                @@
##           release-1.22    #5259      +/-   ##
================================================
- Coverage         43.77%   43.76%   -0.01%     
================================================
  Files               118      118              
  Lines             11720    11721       +1     
================================================
  Hits               5130     5130              
- Misses             6103     6104       +1     
  Partials            487      487

saschagrunert
saschagrunert approved these changes Aug 30, 2021
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 30, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 30, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 30, 2021
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 30, 2021 •
edited

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/openshift-jenkins/integration_crun_cgroupv2 d45f1f1 link /test integration_cgroupv2
ci/openshift-jenkins/e2e_crun_cgroupv2 d45f1f1 link /test e2e_cgroupv2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 011c10a into cri-o:release-1.22 Aug 30, 2021
@openshift-ci openshift-ci bot mentioned this pull request Jan 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@runcom runcom Awaiting requested review from runcom runcom is a code owner

@haircommander haircommander Awaiting requested review from haircommander

Assignees

@saschagrunert saschagrunert

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@openshift-cherrypick-robot @openshift-bot @saschagrunert @openshift-merge-robot