Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.20] BZ#2010831 Fix missing quantile in latency_microseconds_total metrics #5265

Merged
merged 1 commit into from Jan 10, 2022
Merged

[release-1.20] BZ#2010831 Fix missing quantile in latency_microseconds_total metrics #5265

merged 1 commit into from Jan 10, 2022

Conversation

saschagrunert
Copy link
Member

This is an automated cherry-pick of #5258

Fixed missing quantile values in `container_runtime_crio_operations_latency_microseconds_total` metrics

@openshift-ci openshift-ci bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Aug 30, 2021
@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 30, 2021
@saschagrunert saschagrunert changed the base branch from release-1.21 to release-1.20 August 30, 2021 07:43
@saschagrunert saschagrunert changed the title Release 1.20 metrics quantile [release-1.20] Fix missing quantile in latency_microseconds_total metrics Aug 30, 2021
@saschagrunert
Fix missing quantile in latency_microseconds_total metrics
5a64114 
The quantile has to be added manually since a couple of prometheus
client releases and we missed that. Adding an integration test to ensure
that the quantile exist in the future.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@openshift-ci openshift-ci bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Aug 30, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 30, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 30, 2021
@saschagrunert saschagrunert changed the title [release-1.20] Fix missing quantile in latency_microseconds_total metrics [release-1.20] Fix missing quantile in latency_microseconds_total metrics Aug 30, 2021
@saschagrunert
Copy link
Member Author

/retest
@cri-o/cri-o-maintainers PTAL

@haircommander
Copy link
Member

/hold
on 1.21 variant being verified

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 5, 2021
@saschagrunert saschagrunert changed the title [release-1.20] Fix missing quantile in latency_microseconds_total metrics [release-1.20] BZ#2010831 Fix missing quantile in latency_microseconds_total metrics Oct 5, 2021
@saschagrunert
Copy link
Member Author

@haircommander PTAL

@haircommander
Copy link
Member

/hold cancel
/lgtm

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 10, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2022
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit c2b5bcc into cri-o:release-1.20 Jan 10, 2022
@saschagrunert saschagrunert deleted the release-1.20-metrics-quantile branch January 11, 2022 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@runcom runcom Awaiting requested review from runcom runcom is a code owner

@giuseppe giuseppe Awaiting requested review from giuseppe

@vrothberg vrothberg Awaiting requested review from vrothberg

Assignees

@haircommander haircommander

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@saschagrunert @haircommander @openshift-bot @openshift-merge-robot