Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.22] server: do not wait forever on conmon cgroup move fail #5309

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #5306

/assign haircommander

fix a bug where CRI-O waits forever on a conmon process that will not stop

If we haven't signaled on the stop pipe, then conmon will be sitting waiting to be told to start
Instead, we need to kill the process.

Signed-off-by: Peter Hunt <pehunt@redhat.com>
@openshift-ci openshift-ci bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 14, 2021
@openshift-ci openshift-ci bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Sep 14, 2021
@openshift-ci openshift-ci bot requested a review from rhatdan September 14, 2021 19:46
@codecov
Copy link

codecov bot commented Sep 14, 2021

Codecov Report

Merging #5309 (2e42839) into release-1.22 (7a3c55d) will not change coverage.
The diff coverage is 0.00%.

❗ Current head 2e42839 differs from pull request most recent head 85043da. Consider uploading reports for the commit 85043da to get more accurate results

@@              Coverage Diff              @@
##           release-1.22    #5309   +/-   ##
=============================================
  Coverage         43.74%   43.74%           
=============================================
  Files               118      118           
  Lines             11726    11726           
=============================================
  Hits               5130     5130           
  Misses             6109     6109           
  Partials            487      487           

@haircommander
Copy link
Member

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 14, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 14, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 14, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 14, 2021

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/openshift-jenkins/integration_crun_cgroupv2 85043da link false /test integration_cgroupv2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit d54f8e1 into cri-o:release-1.22 Sep 14, 2021
@haircommander
Copy link
Member

/cherry-pick release-1.21

@haircommander
Copy link
Member

/cherry-pick release-1.20

@openshift-cherrypick-robot
Copy link
Author

@haircommander: new pull request created: #5407

In response to this:

/cherry-pick release-1.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link
Author

@haircommander: new pull request created: #5408

In response to this:

/cherry-pick release-1.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants