[e2e fix] server: fix PortForward panic #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mrunalp PTAL |
Closed
|
You can see here the first argument is the sandbox ID, not the infraContainer ID, https://github.com/kubernetes/kubernetes/pull/35661/files#diff-16c44fd3516b9794e49c760f0af2d777R81 |
|
Looks good 👍
…Sent from my iPhone
On May 28, 2017, at 8:32 AM, Antonio Murdaca ***@***.***> wrote:
You can see here the first argument is the sandbox ID, not the infraContainer ID, https://github.com/kubernetes/kubernetes/pull/35661/files#diff-16c44fd3516b9794e49c760f0af2d777R81
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
During "Port forwarding" e2e tests, the following panic happened:
```
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x64981d]
goroutine 52788 [running]:
panic(0x1830ee0, 0xc4200100c0)
/usr/lib/golang/src/runtime/panic.go:500 +0x1a1
github.com/kubernetes-incubator/cri-o/oci.(*Runtime).UpdateStatus(0xc4202afc00,
0x0, 0x0, 0x0)
/home/amurdaca/go/src/github.com/kubernetes-incubator/cri-o/oci/oci.go:549
+0x7d
github.com/kubernetes-incubator/cri-o/server.streamService.PortForward(0xc42026e000,
0x0, 0x0, 0x0, 0x0, 0xc420d9af40, 0x40, 0xc400000050, 0x7fe660659a28,
0xc4201cd0e0, ...)
```
The issue is `streamService.PortForward` assumed the first argument to
be the sandbox's infra container ID, thus trying to get it from memory
store using `.state.containers.Get`. Since that ID is of the sandbox
itself, it fails to get the container object from memory and panics in
`UpdateStatus`.
Fix it by looking for the sandbox's infra container ID starting from a
sandbox ID.
Signed-off-by: Antonio Murdaca <runcom@redhat.com>
runcom
force-pushed
the
port-forward-panic
branch
from
b5eb179
to
1e9ef65
Compare
|
LGTM |
runcom
changed the title
|
60/60 passed on RHEL - Passed. 23/24 passed on Fedora - Failed. 60/60 passed on CentOS - Passed. |
|
all green except oom test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During "Port forwarding" e2e tests, the following panic happened:
The issue is
streamService.PortForwardassumed the first argument tobe the sandbox's infra container ID, thus trying to get it from memory
store using
.state.containers.Get. Since that ID is of the sandboxitself, it fails to get the container object from memory and panics in
UpdateStatus.Fix it by looking for the sandbox's infra container ID starting from a
sandbox ID.
Signed-off-by: Antonio Murdaca runcom@redhat.com