[e2e fix] server: correctly fill ctr termination reason #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
runcom
force-pushed
the
fix-ctr-status-reasons
branch
from
1d64a40
to
c212de8
Compare
This patch fixes all port forwarding e2e tests. Those tests were specifically looking for a termination reason to say that a given container has finished running. CRI-O wasn't actually returning any reason field for an exited container. -> https://github.com/kubernetes/kubernetes/blob/master/test/e2e/portforward.go#L116 -> https://github.com/kubernetes/kubernetes/blob/master/test/utils/conditions.go#L97 Signed-off-by: Antonio Murdaca <runcom@redhat.com>
runcom
force-pushed
the
fix-ctr-status-reasons
branch
from
c212de8
to
ac10267
Compare
runcom
changed the title
`containerdID` is overridden in `s.ctrIDIndex.Get()`, if the ctr is not found it's overridden by an empty string making the error return totally unusable. Signed-off-by: Antonio Murdaca <runcom@redhat.com>
runcom
force-pushed
the
fix-ctr-status-reasons
branch
from
ac10267
to
ad3a3fc
Compare
|
63/63 passed on RHEL - Passed. 63/63 passed on Fedora - Passed. 63/63 passed on CentOS - Passed. |
|
All green here as well |
|
63/63 passed on RHEL - Passed. 26/27 passed on Fedora - Failed. 63/63 passed on CentOS - Passed. |
|
Was planning to do this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes all port forwarding e2e tests. Those tests were
specifically looking for a termination reason to say that a given
container has finished running. CRI-O wasn't actually returning any
reason field for an exited container.
-> https://github.com/kubernetes/kubernetes/blob/master/test/e2e/portforward.go#L116
-> https://github.com/kubernetes/kubernetes/blob/master/test/utils/conditions.go#L97
Signed-off-by: Antonio Murdaca runcom@redhat.com