Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.21] oci: always reap conmon zombies #5510

Merged
merged 1 commit into from Feb 2, 2022
Merged

[release-1.21] oci: always reap conmon zombies #5510

merged 1 commit into from Feb 2, 2022

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #5503

/assign haircommander

Fix a case where conmon children are sometimes leaked

@haircommander
oci: always reap conmon zombies
9f7eee6 
Even if we kill the process, we still need to wait for it, or else we'll reap a zombie.

Signed-off-by: Peter Hunt <pehunt@redhat.com>
@openshift-ci openshift-ci bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Dec 16, 2021
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 16, 2021
Merged
@openshift-ci openshift-ci bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Dec 16, 2021
@haircommander
Copy link
Member

/hold on https://bugzilla.redhat.com/show_bug.cgi?id=2032466 being verified

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 16, 2021
@codecov
Copy link

codecov bot commented Dec 16, 2021

Codecov Report

Merging #5510 (1639613) into release-1.21 (c845cf4) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

❗ Current head 1639613 differs from pull request most recent head 9f7eee6. Consider uploading reports for the commit 9f7eee6 to get more accurate results

@@               Coverage Diff                @@
##           release-1.21    #5510      +/-   ##
================================================
- Coverage         44.90%   44.88%   -0.03%     
================================================
  Files               107      107              
  Lines             10989    10995       +6     
================================================
  Hits               4935     4935              
- Misses             5573     5579       +6     
  Partials            481      481

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 16, 2021 •
edited

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/openshift-jenkins/integration_crun_cgroupv2 9f7eee6 link false /test integration_cgroupv2
ci/openshift-jenkins/e2e_crun_cgroupv2 9f7eee6 link false /test e2e_cgroupv2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@haircommander
Copy link
Member

/retitle [release-1.21] oci: always reap conmon zombies
/approve
/lgtm

@openshift-ci openshift-ci bot changed the title [release-1.21] [release-1.22] oci: always reap conmon zombies [release-1.21] oci: always reap conmon zombies Feb 1, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 1, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 1, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2022
@haircommander
Copy link
Member

/retest-required

@haircommander
Copy link
Member

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 2, 2022
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit c058478 into cri-o:release-1.21 Feb 2, 2022
@haircommander
Copy link
Member

/cherry-pick release-1.20

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 4, 2022
Merged
@openshift-cherrypick-robot
Copy link
Author

@haircommander: new pull request created: #5704

In response to this:

/cherry-pick release-1.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot mentioned this pull request Mar 15, 2022
Closed
@haircommander
Copy link
Member

/cherry-pick release-1.19

@openshift-cherrypick-robot
Copy link
Author

@haircommander: new pull request created: #5774

In response to this:

/cherry-pick release-1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@runcom runcom Awaiting requested review from runcom runcom is a code owner

@giuseppe giuseppe Awaiting requested review from giuseppe

@sboeuf sboeuf Awaiting requested review from sboeuf

Assignees

@haircommander haircommander

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@openshift-cherrypick-robot @haircommander @openshift-bot @openshift-merge-robot