[1.20] Add container out of memory metrics #5706
Conversation
openshift-ci
bot
added
release-note
openshift-ci
bot
added
the
approved
|
Ah this needs more CI fixing |
|
A friendly reminder that this PR had no activity for 30 days. |
saschagrunert
added
the
lifecycle/stale
|
hi @haircommander ! Appreciate the effort to get this backported to 1.20 and was wondering how we can help to move it along and getting it actually merged and released? |
This patch adds a new metric `container_runtime_crio_containers_oom_total` and `container_runtime_crio_containers_oom`, which collects out of memory (oom) metrics global and by container name. This also includes sandboxes, since we reuse the CRI-O internal name for every container. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
haircommander
force-pushed
the
oom-metric-1.20
branch
from
17b8f71
to
42983dc
Compare
|
I've rebased this @saschagrunert can you PTAL |
|
@haircommander: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This patch adds a new metric
container_runtime_crio_containers_oom_totalandcontainer_runtime_crio_containers_oom, which collects out of memory(oom) metrics global and by container name. This also includes
sandboxes, since we reuse the CRI-O internal name for every container.
Signed-off-by: Sascha Grunert sgrunert@redhat.com
What type of PR is this?
/kind feature
What this PR does / why we need it:
cherry-pick of #4690
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?