Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.23] oci: cleanup log path if the container failed to create #5817

Merged
merged 1 commit into from Apr 26, 2022
Merged

[release-1.23] oci: cleanup log path if the container failed to create #5817

merged 1 commit into from Apr 26, 2022

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #5800

/assign rphillips

fix a bug where CRI-O would leak a log file if a container failed to be created and the pod hadn't yet been cleaned up.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 22, 2022
Merged
@openshift-ci openshift-ci bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Apr 22, 2022
@openshift-ci openshift-ci bot requested review from nalind and umohnani8 April 22, 2022 19:37
@openshift-ci openshift-ci bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Apr 22, 2022
@codecov
Copy link

codecov bot commented Apr 22, 2022 •
edited

Codecov Report

Merging #5817 (463e98b) into release-1.23 (04a7c62) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@               Coverage Diff                @@
##           release-1.23    #5817      +/-   ##
================================================
- Coverage         43.01%   43.00%   -0.02%     
================================================
  Files               123      123              
  Lines             12286    12292       +6     
================================================
+ Hits               5285     5286       +1     
- Misses             6494     6499       +5     
  Partials            507      507

saschagrunert
saschagrunert approved these changes Apr 25, 2022
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 25, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2022
@rphillips
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2022
@rphillips
Copy link
Contributor

/cherry-pick release-1.22

@openshift-cherrypick-robot
Copy link
Author

@rphillips: once the present PR merges, I will cherry-pick it on top of release-1.22 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rphillips
Copy link
Contributor

/retest-required

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@haircommander
oci: cleanup log path if the container failed to create
463e98b 
Signed-off-by: Peter Hunt <pehunt@redhat.com>
@haircommander haircommander force-pushed the cherry-pick-5800-to-release-1.23 branch from 2f4aedf to 463e98b Compare April 25, 2022 18:34
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2022
@haircommander
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2022
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 26, 2022 •
edited

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/openshift-jenkins/integration_crun_cgroupv2 463e98b link false /test integration_cgroupv2
ci/openshift-jenkins/e2e_crun_cgroupv2 463e98b link false /test e2e_cgroupv2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 8ad5d25 into cri-o:release-1.23 Apr 26, 2022
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 26, 2022
Merged
@openshift-cherrypick-robot
Copy link
Author

@rphillips: new pull request created: #5825

In response to this:

/cherry-pick release-1.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot mentioned this pull request Oct 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@fidencio fidencio Awaiting requested review from fidencio fidencio is a code owner

@mrunalp mrunalp Awaiting requested review from mrunalp mrunalp is a code owner

@runcom runcom Awaiting requested review from runcom runcom is a code owner

@nalind nalind Awaiting requested review from nalind

@umohnani8 umohnani8 Awaiting requested review from umohnani8

Assignees

@rphillips rphillips

@haircommander haircommander

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@openshift-cherrypick-robot @rphillips @openshift-bot @haircommander @saschagrunert @openshift-merge-robot